| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 667
DYN-9679: Auto-revert to ObjectType when ML autocomplete agreement is unchecked #16616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9679
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements automatic fallback behavior for ML-based node autocomplete when users revoke their data collection agreement. When the ML Terms of Use checkbox is unchecked, the system now automatically switches from ML recommendation mode to ObjectType matching mode, preventing users from remaining in an inconsistent state.
Key Changes:
- Added automatic mode switching logic in the
IsMLAutocompleteTOUApprovedproperty setter - System now reverts to ObjectType matching when ML agreement is unchecked
| isMLAutocompleteTOUApproved = value; | ||
|
|
||
| // If user unchecks the agreement, automatically revert to ObjectType matching | ||
| if (!value && defaultNodeAutocompleteSuggestion == NodeAutocompleteSuggestion.MLRecommendation) | ||
| { | ||
| defaultNodeAutocompleteSuggestion = NodeAutocompleteSuggestion.ObjectType; | ||
| AutocompletePreferencesChanged?.Invoke(); | ||
| } | ||
|
|
||
| RaisePropertyChanged(nameof(IsMLAutocompleteTOUApproved)); |
Copilot
AI
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property change notification for IsMLAutocompleteTOUApproved should be raised before potentially triggering AutocompletePreferencesChanged. The current order may cause event handlers to observe inconsistent state where the autocomplete mode has changed but IsMLAutocompleteTOUApproved hasn't been signaled yet. Move RaisePropertyChanged(nameof(IsMLAutocompleteTOUApproved)) to line 821, immediately after setting the backing field.
| if (!value && defaultNodeAutocompleteSuggestion == NodeAutocompleteSuggestion.MLRecommendation) | ||
| { | ||
| defaultNodeAutocompleteSuggestion = NodeAutocompleteSuggestion.ObjectType; | ||
| AutocompletePreferencesChanged?.Invoke(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kalunkuo Would you remind me what this does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It automatically switches the "the default ranking method" from "Recommended Nodes/ MLRecommendation" to "Node Type Match/ ObjectType" when the user unchecks the agreement, because to use the Recommended Nodes ranking method with Node Autocomplete, user must agree to data collection in Dynamo.
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
|
Successfully created backport PR for |
Labels
3 participants
Purpose
When users uncheck the "Agreement for Data Collection" checkbox for ML-based node autocomplete, the system now automatically reverts to ObjectType matching mode.
Problem:
Users could uncheck the ML agreement but remain in ML recommendation mode, they had to manually switch back to ObjectType mode
Solution:
Added automatic fallback logic in
IsMLAutocompleteTOUApprovedsetterDeclarations
Check these if you believe they are true
Release Notes
ML autocomplete now automatically reverts to ObjectType matching when users uncheck the data collection agreement.
Reviewers
@DynamoDS/eidos @DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of