| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 31 Dec 2025 03:21:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=463.6683,conversation_content-fragment;desc="conversation_content fragment";dur=2231.111898,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=470.849525,nginx;desc="NGINX";dur=1.314442,glb;desc="GLB";dur=97.298333
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=3dD4up9QeNmQWN7bHF5ihuwRkZzpQUWxN0SJhcN5aHUF8LrBHyYzM10v3jLK4dh5fhJ3U6bV0IIXY5pBsDJRsyWWP%2B%2Bthsc3bZ4SZiRkk8ng7vuvxCLXQtNttAFGCMpahEipPynkGTGShYMeVWzg0WSQFumb7qkMWImVm5oBLB4NgNK3iQ%2BCdBBwJjvKr86HzZG21vF6ZjcFX5TKsY6rzM4gmRYfnPXetoW16kWHRxleokgEv%2Fsq275UYnWTRBgW8X0vBnrWfd4f1NmTvee74A%3D%3D--hi6xwq2bgBkLLBmT--vU3AjyHeanxqLtnNwaa8MQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1790872354.1767151289; Path=/; Domain=github.com; Expires=Thu, 31 Dec 2026 03:21:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 31 Dec 2026 03:21:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E736:1D35DB:135A8AF:15FA468:695496B9
DYN-8879: Check mark to graph properties menu item by ivaylo-matov · Pull Request #16608 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 667
DYN-8879: Check mark to graph properties menu item #16608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8879
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a checkmark/toggle behavior for the File > Show Graph Properties > General menu item by binding it to the GraphMetadata extension menu item, mirroring previous Extensions menu behavior.
- Introduces BindGraphPropertiesMenu to bind and optionally toggle the extension-driven check state.
- Adds a field (graphMetadataHooked) to ensure event handlers are only attached once.
Contributor
zeusongit
reviewed
Oct 21, 2025
QilongTang
reviewed
Oct 21, 2025
QilongTang
reviewed
Oct 21, 2025
Contributor
QilongTang
left a comment
QilongTang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment then LGTM
Contributor
reddyashish
approved these changes
Oct 22, 2025
Contributor
|
This job seems to never complete after the last commit. The jira task is also marked for 4.1. |
Contributor
@reddyashish Would you re-run the job? |
Contributor
Contributor
|
The last job also timed out and shows this "message":"This SHA and context has reached the maximum number of statuses.". The changes look straightforward and could be an issue with the this branch commits. @ivaylo-matov if you can open another PR with the same changes and close this, we can check the test job. |
Contributor
|
Thanks Aaron, Merging this. The jira task is marked for 4.1 though. so not cherrypicking yet. |
Contributor
|
@reddyashish @zeusongit Notice this is a follow up of #16476 so the earlier PR is already part of 4.0 release |
Contributor
|
should be cherry-picked |
Contributor
|
/cherrypick |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
Co-authored-by: Aaron (Qilong) <173288704@qq.com> (cherry picked from commit e10e993)
3 tasks
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
PR to address latest comments in DYN-8879.
Adds a checkmark to the File > Show Graph Properties > General menu item and allow clicking it to toggle the panel. This mirrors the behavior the item had when it lived under the Extensions menu.
The new BindGraphPropertiesMenu method subscribes using lambda event handlers. This should be fine here because the subscriber’s lifetime matches the DynamoView window lifetime.
Declarations
Check these if you believe they are true
Release Notes
Adds a checkmark to the File > Show Graph Properties > General menu item and allow clicking it to toggle the panel. This mirrors the behavior the item had when it lived under the Extensions menu.
Reviewers
@DynamoDS/eidos
FYIs
@dnenov
@achintyabhat