| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 666
DYN-9658: Correctly adds file information to pacman when publishing from custom node workspace #16603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-9658: Correctly adds file information to pacman when publishing from custom node workspace #16603
Conversation
- now correctly refreshes the datacontext and triggers update to the UI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9658
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug where custom nodes (.dyf files) published via "Publish → Publish Custom Node (.dyf)" menu didn't appear in the package contents of the publish wizard. The issue was caused by the wizard only populating CustomNodeDefinitions without setting CustomDyfFilepaths, causing the UI to show empty package contents since it filters out CustomNode items and only displays CustomNodePreview items.
- Populate
CustomDyfFilepathsbefore settingCustomNodeDefinitionsto ensure proper UI display - Add fallback to use workspace.FileName when CustomNodeInfo.Path is empty
- Enhance pending update detection logic to check for actual content availability
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PackageManagerClientViewModel.cs | Adds logic to populate CustomDyfFilepaths dictionary and fallback for empty Path values |
| PublishPackageViewModel.cs | Changes CustomDyfFilepaths property visibility from private to internal |
| PackageManagerWizard.xaml.cs | Improves pending update detection by checking content availability and fixes typo in comment |
| currentFunInfo = new CustomNodeInfo( | ||
| currentFunInfo.FunctionId, | ||
| currentFunInfo.Name, | ||
| currentFunInfo.Category, | ||
| currentFunInfo.Description, | ||
| ws.FileName, // Use workspace FileName | ||
| currentFunInfo.IsVisibleInDynamoLibrary); |
Copilot
AI
Oct 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Creating a new CustomNodeInfo object to modify only the Path property is inefficient. Consider adding a constructor overload or a method to update the Path property directly, or use object initialization syntax to make the intent clearer.
| currentFunInfo = new CustomNodeInfo( | |
| currentFunInfo.FunctionId, | |
| currentFunInfo.Name, | |
| currentFunInfo.Category, | |
| currentFunInfo.Description, | |
| ws.FileName, // Use workspace FileName | |
| currentFunInfo.IsVisibleInDynamoLibrary); | |
| currentFunInfo.Path = ws.FileName; // Update Path directly |
Purpose
This PR addresses the issue where Custom nodes (.dyf files) published via "Publish → Publish Custom Node (.dyf)" menu didn't appear in the package contents in the publish wizard.
Cause
ShowNodePublishInfo()only populatedCustomNodeDefinitionsbut notCustomDyfFilepaths. The wizard filters outCustomNodetype items and only displaysCustomNodePreviewtype items (created fromCustomDyfFilepaths), resulting in empty package contents.Solution
CustomDyfFilepathswith file paths fromCustomNodeInfobefore settingCustomNodeDefinitions(which triggersRefreshPackageContents())OnDataContextChangedto checkCustomDyfFilepathscount in addition to HasChanges for proper pending update detectionChanges
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@zeusongit
FYIs
@benglin