| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 666
DYN-3647: Update libg for a couple of perf optimizations #16590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the libg (geometry library) dependency across the Dynamo codebase to incorporate performance optimizations for key geometric operations. The update moves from version 4.0.0.2726 to 4.0.0.2826.
Key changes:
- Updates libg version to include performance improvements for PolySurface.ByJoinedSurfaces, point projection, PolyCurve.Offset, and Boolean operations
- Maintains consistency across all project files that reference the geometry library
- Includes both release and debug variants of the library dependency
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/DynamoCore/DynamoCore.csproj | Updates core libg dependencies including LibG_231_0_0, LibG_232_0_0, and debug variant |
| src/DynamoCoreWpf/DynamoCoreWpf.csproj | Updates libg dependency for WPF components |
| src/DynamoManipulation/DynamoManipulation.csproj | Updates libg dependency for manipulation features |
| src/Libraries/Analysis/Analysis.csproj | Updates libg dependency for analysis library |
| src/Libraries/CoreNodes/CoreNodes.csproj | Updates libg dependency for core nodes |
| src/Libraries/GeometryColor/GeometryColor.csproj | Updates libg dependency for geometry color functionality |
| src/Libraries/GeometryUI/GeometryUI.csproj | Updates libg dependency for geometry UI components |
| src/Libraries/GeometryUIWpf/GeometryUIWpf.csproj | Updates libg dependency for WPF geometry UI |
| src/Libraries/Tesellation/Tessellation.csproj | Updates libg dependency for tessellation library |
| src/Tools/NodeDocumentationMarkdownGenerator/NodeDocumentationMarkdownGenerator.csproj | Updates libg dependency for documentation generator |
| test/Libraries/AnalysisTests/AnalysisTests.csproj | Updates libg dependency for analysis tests |
| test/Libraries/DynamoPythonTests/DynamoPythonTests.csproj | Updates libg dependency for Python tests |
| test/Libraries/GeometryColorTests/GeometryColorTests.csproj | Updates libg dependency for geometry color tests |
| test/Libraries/TestServices/TestServices.csproj | Updates libg dependency for test services |
| test/Libraries/WorkflowTests/WorkflowTests.csproj | Updates libg dependency for workflow tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-3647
Purpose
Update libg for a couple of perf optimizations.
Declarations
Check these if you believe they are true
Release Notes
--
PolySurface.ByJoinedSurfacesand Point projection (https://jira.autodesk.com/browse/DYN-3647)--
PolyCurve.Offset(https://jira.autodesk.com/browse/DYN-9381)-- Solid and Surface Union and Difference nodes (https://jira.autodesk.com/browse/DYN-8841)
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of