| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 30 Dec 2025 07:13:01 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=403.017273,conversation_content-fragment;desc="conversation_content fragment";dur=896.161172,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=358.82903,nginx;desc="NGINX";dur=0.927322,glb;desc="GLB";dur=97.004219
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Q69M34lQHApGEkjmWKmLkbGofp0IVk%2FEbW5%2FJRYieOZrpoO7ZD0XsNxw2z6cV4p7bEq6WIDDKiPlyWsHY65VbJ1YNBti7QsLULgZIC0QtlM3d%2BiDGc5rv2i3YnFAlGQYfvuUeepu4Tv4k%2B%2FnqSBMAz45JO7nVk%2FN45KFAP7YmmfqeBdbBO1AmffDGQVrQuT9LOU299IfXATWwqUVhx7A6dv7vHJumJpuwS2YSs5%2B9OtuA96GioI2CeIRoVGh3KkS4vuuu4z7axNhilMojXRTiw%3D%3D--kynMHbJkpYeft96Q--Mc5Cm0w8rlgUg9E%2Bh5o8jA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1808405729.1767078780; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 07:13:00 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 07:13:00 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B138:2B8C22:34E9F2:3A2382:69537B7C
DYN-9533: Update protogeometry.config, update ASM file mask for ASM 232 by aparajit-pratap · Pull Request #16569 · DynamoDS/Dynamo · GitHub
Copy link
aparajit-pratap
changed the title
Update protogeometry.config, update ASM file mask
Update protogeometry.config, update ASM file mask for ASM 232
Oct 3, 2025
aparajit-pratap
changed the title
Update protogeometry.config, update ASM file mask for ASM 232
DYN-9533: Update protogeometry.config, update ASM file mask for ASM 232
Oct 3, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 666
DYN-9533: Update protogeometry.config, update ASM file mask for ASM 232 #16569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes geometry test failures by updating the ProtoGeometry configuration to point to the correct libg subfolder and updating the ASM file mask pattern to accommodate One ASM naming changes.
- Updated ProtoGeometry.config to reference the correct libg version (232_0_0 instead of 231_0_0)
- Modified ASM file mask to remove suffix requirement due to One ASM binary naming changes
- Removed failure category from a geometry test that should now pass
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extern/ProtoGeometry/ProtoGeometry.config | Updates GeometryFactoryFileName path from libg_231_0_0 to libg_232_0_0 |
| src/Tools/DynamoShapeManager/Utilities.cs | Removes 'A' suffix from ASM file mask pattern to match One ASM naming |
| test/Libraries/WorkflowTests/GeometryDefectTests.cs | Removes [Category("Failure")] attribute from geometry test |
aparajit-pratap
changed the title
aparajit-pratap
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9533
QilongTang
reviewed
Oct 3, 2025
| } | ||
|
|
||
| [Test] | ||
| [Category("Failure")] |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is expected diff after ASM 232 update, do we need a task to fix this later?
QilongTang
approved these changes
Oct 3, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment that we can address later. Merging and going to trigger a new build, restore master-15 is the top priority now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
I believe geometry tests are failing due to the
protogeometry.configfile pointing to the wrong libg subfolder corresponding to the ASM version that's on the CI machines. This could be one of the issues why no new daily builds for 4.0 are being published to dynamobuilds.com.Additionally due to the One ASM changes, there is no
AorIsuffix to ASM binary naming anymore, due to which the ASM file mask we're using to search for ASM installations needs to be updated.Declarations
Check these if you believe they are true
Release Notes
N/A
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of