You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dnenov, can you explain why we added net8 and net10 target frameworks to DynamoServices? Could we not have left it as netstandard?
I only added net10 as part of this PR, following the logic we had before. We had both net8.0 and netstandard2.0. In essence, we added .NET 10 target and keep .NET 8 / netstandard2.0 for compatibility. There was a separate jira ticket for multitarget support here:
@QilongTang, my question was why the task was created to multitarget DynamoServices (was there a specific need). I suppose there is no harm in doing this, just wanted to understand.
@QilongTang, my question was why the task was created to multitarget DynamoServices (was there a specific need). I suppose there is no harm in doing this, just wanted to understand.
I think it was already multi-targeting even before the .NET10 introduction so it was not a new practice?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Update to nuget
Declarations
Check these if you believe they are true
Release Notes
Reviewers
@QilongTang
@avidit
FYIs