| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 31 Dec 2025 07:42:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=495.696238,conversation_content-fragment;desc="conversation_content fragment";dur=1134.17127,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=350.491,nginx;desc="NGINX";dur=1.190461,glb;desc="GLB";dur=104.079483
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TQMw1qHBYC5ixA0BMau1AzyLR5HzoiHTApUxiy3Nl4JJlC7PsvEO8BKa%2FOwDKyGW7yf4ZEUwtse73GGGgl%2B4R0pzNBDRzzeMa6nZ%2BzGR6bupDQrp%2BqujPdAS52ElSGfPqRdh%2FVTO2jQrg1OKF1V8hd5Qtytqd3j3bDzZwvqE0nqi%2BbKkEkfMr82uXdx7w7S%2FE3WU1V8Xcv4id13Uvn0xGWh%2BdEdkXu1fXHi2qpCbWS1fOqvEuCxWcSbZ4UWQs2R%2FQR9Pz4miFcYVpmQk8mkGEA%3D%3D--WJngIPEGJYdnm5oy--1Cd0N2JuaSSk0MFU2IDCJQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.847938481.1767166940; Path=/; Domain=github.com; Expires=Thu, 31 Dec 2026 07:42:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 31 Dec 2026 07:42:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DE80:1D06DD:17EF098:1B0BA45:6954D3DC
DYN-9379: Fix connection aborted when panning by chubakueno · Pull Request #16519 · DynamoDS/Dynamo · GitHub
chubakueno
changed the title
Fix connection aborted when panning
DYN-9379: Fix connection aborted when panning
Sep 25, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 667
DYN-9379: Fix connection aborted when panning #16519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chubakueno
changed the title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9379
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a regression where connections were incorrectly aborted when the user panned using the middle mouse wheel. The fix prevents pan mode from being toggled when the user is actively connecting nodes.
- Added connection state checks to prevent pan mode interference during node connections
- Applied the fix to both mouse down and mouse release events for middle mouse button
reddyashish
approved these changes
Sep 25, 2025
johnpierson
approved these changes
Sep 25, 2025
Member
johnpierson
left a comment
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. tested with a few different scenarios!
Comment on lines
+953
to
956
| if (!ViewModel.IsConnecting && ViewModel.IsPanning && e.MiddleButton == MouseButtonState.Released) | ||
| { | ||
| ViewModel.RequestTogglePanMode(); | ||
| } |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious how this worked before since this code looks like it was introduced only in 3.6 (seeing the PRs referenced in the description). Was there a call to RequestTogglePanMode elsewhere in the code?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Connecting mode allows for panning, but when you explicity request Panning mode, Panning mode does not allow for connection.
Contributor
|
@jnealb is there a way to add UI tests (AGT Tests) for these behaviors (like zoom, pan, etc.) so we make sure such regressions don't reoccur in the future? |
Member
|
@aparajit-pratap added a test here: https://jira.autodesk.com/browse/DYN-9598 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
A regression was introduced in ticket #16285 which was based upon PR #15823 in which a connection was aborted when panning with the middle mouse wheel. This PR aims to fix such behavior.
Declarations
Check these if you believe they are true
Release Notes
Fix abortion of connection when panning with middle wheel.
Reviewers
@johnpierson
@reddyashish
FYIs
@dimven-adsk