| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 667
DYN-9387: Take Panel Nodes out of experimental #16518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9387
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Panel nodes from experimental status, making them available as regular nodes in the Dynamo library. The change involves cleaning up all Panel-related experimental infrastructure that was previously used to toggle their visibility.
- Removed Panel namespace from experimental collection
- Removed Panel-specific UI toggle and related properties from preferences
- Removed Panel namespace migration code for backwards compatibility
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PreferencesView.xaml | Removed Panel toggle UI elements from preferences window |
| PreferencesViewModel.cs | Removed EnablePanelingIsChecked property and tooltip handling |
| PreferenceSettings.cs | Removed Panel from experimental namespaces and migration logic |
|
With panel nodes now OOTB, the experimental expander can be removed/hidden IMO, unless there is something else planned to be added. What do you think? @achintyabhat @mjkkirschner @aparajit-pratap |
|
Oh I also noticed TSpline is still in experimental as well, it's hidden for now. I don't know if there is a task for it, should I also remove it? |
I would remove it. Seems like dead code. |
I agree, we should at the most hide it from the UI. I would keep the UI and basic infrastructure around for future proofing for features that may come in the future that we may wish to treat in the same way - i.e., an initial experimental baking period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
johnpierson
left a comment
johnpierson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally and this all lgtm
Labels
4 participants
Purpose
This PR takes Panel Nodes out of experimental.
Key changes:
PanelSurface
PanelSurfacefromInitialExperimentalLib_NamespacescollectionEnablePanelingIsCheckedproperty and related tooltip handlingTSpline
TSplinefrom experimental expanderExperimental expander
Declarations
Check these if you believe they are true
Release Notes
Panel Surface nodes have been removed from experimental status and are now permanently available in the Geometry library.
Reviewers
@DynamoDS/synapse
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of