You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you previously used Dynamo 4.0.0 and now with the previous fix try to use it, you will see that is loading packages from C:\ProgramData\Dynamo\Dynamo Core\4.0\packages. The problem is that DynamoSettings.xml in C:\Users\tellro\AppData\Roaming\Dynamo\Dynamo Core\4.0 already contains the entry for ProgramData then you need to delete the Dynamo cache in order to verify my fix.
With this fix doesn't matter if the Dynamo cache was deleted or not, now it won't be loading any package from the ProgramData path.
f you previously used Dynamo 4.0.0 and now with the previous fix try to use it, you will see that is loading packages from C:\ProgramData\Dynamo\Dynamo Core\4.0\packages.
The problem is that DynamoSettings.xml in C:\Users\tellro\AppData\Roaming\Dynamo\Dynamo Core\4.0 already contains the entry for ProgramData then you need to delete the Dynamo cache in order to verify my fix.
With this fix doesn't matter if the Dynamo cache was deleted or not now it won't be loading any package from the ProgramData path.
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where Dynamo continues to load packages from the ProgramData directory even after a previous fix was intended to prevent this behavior. The problem occurs when users upgrade from older Dynamo versions that have ProgramData entries cached in their DynamoSettings.xml file.
Key Changes:
Enhanced package directory filtering to explicitly exclude ProgramData paths
Added programmatic detection of the ProgramData folder path using Environment.GetFolderPath
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
If you previously used Dynamo 4.0.0 and now with the previous fix try to use it, you will see that is loading packages from C:\ProgramData\Dynamo\Dynamo Core\4.0\packages. The problem is that DynamoSettings.xml in C:\Users\tellro\AppData\Roaming\Dynamo\Dynamo Core\4.0 already contains the entry for ProgramData then you need to delete the Dynamo cache in order to verify my fix.
With this fix doesn't matter if the Dynamo cache was deleted or not, now it won't be loading any package from the ProgramData path.
Declarations
Check these if you believe they are true
Release Notes
Fixing problem that is loading packages from ProgramData due that a previous version of Dynamo that doesn't have my fix was used
Reviewers
@reddyashish @zeusongit @QilongTang
FYIs