| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 30 Dec 2025 04:57:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=426.96215,conversation_content-fragment;desc="conversation_content fragment";dur=1466.152414,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=273.622805,nginx;desc="NGINX";dur=0.662005,glb;desc="GLB";dur=96.66394
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=6g5aTzy58wIKh0xmX9Ihjn5jF5%2FEgi59HMym8W4%2FvHTr47Q2ay5VSMw4U0fvgGKyaVcUdVIpZYV6JtRPIM3U7HOs4Vp4h2%2FawirZ4UqU54GKc8pkYWgNpWnQY9MA%2BWOELPtGfuIIMm7o4YhE0aBcJWFtkhAbgLTFHb2hksLF2D56KuEUifmhQwip1zArO8mFOX%2F3ekGZperkFswshV5ZQDRyDNoAT1kK00GgrYPrNXfTHQNr1mGxan2dMGz1bIzUhnQjP1tWJOvwQJT%2B%2FM2u7w%3D%3D--HXa8qsPysavXYNhL--LisHZn2kg9r28BT38UrCUg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1523169278.1767070676; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 04:57:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 04:57:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8344:D9BF:A5996:BAE95:69535BD4
DYN-7145: handle large package upload by dnenov · Pull Request #16375 · DynamoDS/Dynamo · GitHub
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4)
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 666
DYN-7145: handle large package upload #16375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactored code to support async files and folders loading, moving the heavy UI-blocking operations to a sub thread
- changes to allow responsive frontend for cancellation and progress indication
- small null check for compatibilityMapList when loading Dynamo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7145
- revert accidental change to the reset function
- created tests for the new functionalities - aggregate warnings to prevent multiple prompts popping up during the async process - surface warnings/errors to the user once the loading is completed
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses DYN-7145 to improve Dynamo's handling of large package uploads by implementing asynchronous file processing and progress reporting. The change prevents Dynamo from hanging when processing packages with large numbers of files (>1GB was not actually the issue, but rather large file counts).
Key changes:
- Implemented asynchronous file processing with progress updates and cancellation support
- Added UI progress indicators and cancellation capabilities for large file operations
- Enhanced error handling and batch processing for better responsiveness
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs |
Added comprehensive async tests and updated existing tests to use async methods |
src/DynamoPackages/PackageManagerClient.cs |
Added duplicate null check for compatibility map |
src/DynamoCoreWpf/Views/PackageManager/Components/PackageManagerWizard/PackageManagerWizard.xaml.cs |
Added upload progress and cancellation support to the wizard UI |
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs |
Implemented async file processing with progress reporting and cancellation |
src/DynamoCoreWpf/PublicAPI.Unshipped.txt |
Updated API surface for new async functionality |
src/DynamoCoreWpf/Properties/Resources.resx |
Added new localized error messages for multiple file failures |
src/DynamoCoreWpf/Properties/Resources.en-US.resx |
Added English translations for new error messages |
Files not reviewed (1)
- src/DynamoCoreWpf/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (1)
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs:1
- The removal of Thread.Sleep(500) may cause timing issues in UI tests. Consider adding a small wait or assertion that ensures the window is fully initialized before the assertion.
using System;
test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+2062
to
+2063
| UploadState = PackageUploadHandle.State.Uploading; | ||
| Uploading = true; |
Copilot
AI
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider consolidating these state changes into a single method to avoid potential inconsistencies. The same pattern appears multiple times throughout the file.
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am bit hesitant to touch that logic - we use Uploading 19 times (references), and 33 for UploadState. This is legacy code and touches quite a few parts of our logic. If you think this needs rework, I would dedicate a separate PR for that @zeusongit
src/DynamoCoreWpf/ViewModels/PackageManager/PublishPackageViewModel.cs
Outdated
Show resolved
Hide resolved
- addressing misc comments from the team
Contributor
|
1 test fails, but unrelated, merging: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/18579/ |
zeusongit
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
Addresses https://jira.autodesk.com/browse/DYN-7145(https://jira.autodesk.com/browse/DYN-7145): As a Dynamo Dev, Dynamo should not hang and crash when the package upload is more than 1 GB.
Frontend PR - https://git.autodesk.com/Dynamo/PackagePublishWizard/pull/52
Analysis
The issue postulates that the PM cannot handle large packages - packages above 1Gb of data, and causes Dynamo to crash. Running a small amount of large files disproves this statement, as shown below. However, processing a large number of files is handled poorly at the moment, and without a UI update, causes the user to think Dynamo has crashed, although eventually the files will be processed.
> 1 Gb not a problem in itself
Introducing UI visual cue to show the progress of processing files as well as offloading this process from the main thread dramatically enhances the user experience.
Async process of file loading with progress update - processing Dynamo build with over 18k files
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
@jasonstratton
@zeusongit
FYIs
@QilongTang