| CARVIEW |
Select Language
HTTP/2 200
date: Tue, 30 Dec 2025 07:10:55 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com github.githubassets.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=384.218159,conversation_content-fragment;desc="conversation_content fragment";dur=1134.454941,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=279.349739,nginx;desc="NGINX";dur=1.334857,glb;desc="GLB";dur=97.145952
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ebsmEmRUMiSAcJ%2FqEgpOkr%2BwzKzr%2FFWO5tPlJ%2BE3EfVghc1JufpAObH%2B%2BxCbeKZEX701Rx6f7cu4qU3kPuZX2OPlGUygk1vYBie6hk%2FgLSI45aM5DxvIQJcwB%2BbtFDQS1CUKKgo7O5Gs%2FT5tH0hpIi%2FXw6JZVe9lGoUarGepL52aIH2vh5IkO9G1LYBdAQxq6lbCLc%2BczgTGJ9RiMfMLx%2BgCqivkFvzl7Ewzili0gmgTQUusV5sGN%2BUPwCiETiE1jZMQf0s3fwy625UDQuAQ5Q%3D%3D--pCEbY%2Bhc8CE99Rd3--S96t43KpnKiByV6xEM8xIw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.440307550.1767078654; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 07:10:54 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 30 Dec 2026 07:10:54 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B508:14CF36:347BFD:39A478:69537AFE
As a Dynamo integrator I want to control where my nodes are located in the library by mjkkirschner · Pull Request #12848 · DynamoDS/Dynamo · GitHub
mjkkirschner
changed the title
Layout
As a Dynamo integrator I want to control where my nodes are located in the library
May 2, 2022
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Copy link
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 666
As a Dynamo integrator I want to control where my nodes are located in the library #12848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it does not stop the types from also showing in addons section and it includes a hack to wait for the library view
new viewextensionmanager constructor
add new tests comment out old tests
mjkkirschner
changed the title
pinzart90
reviewed
May 3, 2022
| /// </summary> | ||
| public static string GetFullyQualifiedName(NodeSearchElement element) | ||
| { | ||
| if (element.ElementType.HasFlag(ElementTypes.Packaged) && element.ElementType.HasFlag(ElementTypes.BuiltIn)) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not add this condition inside the if at line 88 ?
if (element.ElementType.HasFlag(ElementTypes.Packaged))
{
if (element.ElementType.HasFlag(ElementTypes.BuiltIn) {
return string.Format("{0}{1}.{2}", "bltinpkg://", element.FullCategoryName, element.Name);
}
//Use FullCategory and name as read from _customization.xml file
return string.Format("{0}{1}.{2}", "pkg://", element.FullCategoryName, element.Name);
}
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like using nested if statements if avoidable, if you much prefer your sample code I will make the switch.
Member
Author
|
latest tests finally ran and did not introduce any new regressions! |
sm6srw
approved these changes
May 5, 2022
Contributor
sm6srw
left a comment
sm6srw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
| { | ||
| //try to combine the layout specs. | ||
| var customizationService = extensionManager.Service<ILibraryViewCustomization>(); | ||
| //TODO if the layoutspec is empty, we're calling this too early, we can retry after x seconds? |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you seen this happening?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but only before when I was calling this code from the ExtensionsManager (before view extensions like libraryjs were loaded)
pinzart90
approved these changes
May 5, 2022
Contributor
pinzart90
left a comment
pinzart90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Purpose
https://jira.autodesk.com/browse/DYN-3407
For built-in packages Dynamo host product integrators should have a way of modifying the library layout spec so that their packages show up in the main sections of the library, and not the "add-on" section.
This PR does the following:
MergeLayoutSpecsmethod. This method can merge sections and categories of two layout specs objects. It does not merge data, only child elements. For example, it won't combineIncludeInfoorIconUrlof elements, it will only merge their child element collections.pkg/extra/layoutspecs.jsonfile, will trigger a layout spec application request.libraryViewExtensionis loaded , it will handle the request and attempt to merge the two layout specs.BuiltInflag, in addition to thePackagedflag.bltinpkg://as opposed topkg://for normal packages. This is the prefix that should be applied to the paths that integrators put in their layoutspec file.LibraryViewExtension(CEF)as a dep and instead pointed toLibraryViewExtensionMSWebbrowser. Most of the tests for the old library have been commented out as these simply don't make sense or don't compile. It's a bigger task to get these working again, and we'll be tossing the MSWebBrowser implementation soon anyway for WebView2 hopefully.Here is an example of moving the zero touch dynamo samples package into a category named
RevitDeclarations
Check these if you believe they are true
*.resxfilesRelease Notes
Internal API for Dynamo integrators to modify the library layout for their builtin packages.
Reviewers
...