HTTP/2 200 cache-control: max-age=43200 server: Combust/Plack (Perl) vary: Accept-Encoding content-encoding: gzip content-length: 1786 content-type: text/html; charset=utf-8 last-modified: Wed, 15 Oct 2025 02:01:50 GMT date: Wed, 15 Oct 2025 02:01:50 GMT strict-transport-security: max-age=15768000 Front page | perl.perl5.porters | Postings from January 2015

[perl #123413] [PATCH] Update SDBM_File Makefile.PLs

On Mon Dec 29 04:05:31 2014, etj@cpan.org wrote:
> > Since the SDBM library code dir has already been modified by adding a
> > Makefile.PL in it, I propose to change the layout of
> > https://perl5.git.perl.org/perl.git/tree/HEAD:/ext/SDBM_File a little
> > further such that the two directories are merged.
> 
> In fact I got a bit carried away and actually implemented this,
> against latest blead. All SDBM_File tests pass on my system. Please
> find attached patch. The only Makefile.PL now reads:
> 
> use strict; use warnings;
> use ExtUtils::MakeMaker;
> 
> my $define = '-DSDBM -DDUFF';
> # no -DMSDOS because MSDOS and WIN32 treated same in code
> $define .= ' -DWIN32 -DPERL_STATIC_SYMS' if ($^O eq 'MSWin32');
> 
> WriteMakefile(
>     NAME      => 'SDBM_File',
>     VERSION_FROM => 'SDBM_File.pm',
>     DEFINE    => $define,
>     INC       => '-I$(PERL_INC)', # force PERL_INC dir ahead of system
> -I's
>     OBJECT    => '$(O_FILES)',
>     clean     => {'FILES' => 'dbu libsdbm.a dbd dba dbe x-dbu *.dir
> *.pag'},
>     H         => [qw(tune.h sdbm.h pair.h $(PERL_INC)/config.h)],
>     C         => [qw(SDBM_File.c sdbm.c pair.c hash.c)],
> );
I see a couple of problems with the patch as is:
a) MANIFEST wasn't updated, so Configure complains about the missing files and aborts
b) you're no longer building libsdbm.a, so there's no need to remove it in the clean entry.
Tony
---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=123413

• [perl #123413] [PATCH] Update SDBM_File Makefile.PLs by Tony Cook via RT