HTTP/2 200 cache-control: max-age=43200 server: Combust/Plack (Perl) vary: Accept-Encoding content-encoding: gzip content-length: 2052 content-type: text/html; charset=utf-8 last-modified: Mon, 13 Oct 2025 22:08:10 GMT date: Mon, 13 Oct 2025 22:08:10 GMT strict-transport-security: max-age=15768000 Front page | perl.perl5.porters | Postings from January 2015

[perl #123169] Bleadperl breaks KARMAN/Template-Plugin-Autoformat-2.75.tar.gz

On Wed Dec 17 21:20:58 2014, khw wrote:
> On Fri Dec 12 21:00:47 2014, public@khwilliamson.com wrote:
> > On 12/12/2014 06:05 PM, James E Keenan via RT wrote:
> > > On Thu Nov 13 21:21:12 2014, public@khwilliamson.com wrote:
> > >> On 11/12/2014 06:25 PM, James E Keenan via RT wrote:
> > >>> On Mon Nov 10 12:53:35 2014, slaven@rezic.de wrote:
> > >>>> The test suite fails for perl 5.21.x if a German locale is in
> > >>>> effect.
> > >>>> See https://rt.cpan.org/Ticket/Display.html?id=99972 for details.
> > >>>> This
> > >>>> is probably a duplicate of
> > >>>> https://rt.perl.org/Public/Bug/Display.html?id=122367 , but that
> > >>>> ticket was already closed.
> > >>>>
> > >>>> Regards,
> > >>>>       Slaven
> > >>>
> > >>> Slaven, can you describe how someone (like me) who normally need pay
> > >>> no attention to locales could prepare an environment in which this
> > >>> bug could be reproduced for further study?
> > >>>
> > >>> Thank you very much.
> > >>> Jim Keenan
> > >>>
> > >>>
> > >>
> > >> Indeed the error was introduced by the change to localeconv() to
> > >> always
> > >> use the underlying locale.  Some modules want it one way, and some the
> > >> other.  The change is the most logical way forward, and indeed,
> > >> commented out code in the test files here indicate that the test
> > >> writer
> > >> expected that to be the case, as it calls localeconv() without doing a
> > >> 'use locale'.  It was just luck that it used to work.
> > >>
> > >> The comments indicate that it is known that locales with a non-dot
> > >> radix
> > >> don't work.  That tells me that all that needs to be done is for the
> > >> tests to change the locale to one with a dot radix, to make sure that
> > >> a
> > >> dot is being used.
> > >>
> > >> I have done this locally, and the tests pass.  I will issue a pull
> > >> request on this if it is agreed that that is the way to go
> > >
> > > Karl, can you provide an update on the status of this ticket?
> > >
> > > Thank you very much.
> > > Jim Keenan
> > >
> > 
> > There was no encouragement/discouragement from anyone so I haven't done 
> > anything.
> > 
> 
> I have now issued a pull request
> https://github.com/karpet/template-plugin-autoformat/pull/1
That pull request has now been merged
https://github.com/karpet/template-plugin-autoformat/pull/1
-- 
Karl Williamson
---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=123169

• [perl #123169] Bleadperl breaks KARMAN/Template-Plugin-Autoformat-2.75.tar.gz by Karl Williamson via RT