| CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/gulpjs/glob-parent/issues/53
strict-transport-security: max-age=31536000; includeSubDomains; preload
HTTP/2 302
date: Wed, 30 Jul 2025 23:01:02 GMT
content-length: 0
location: https://github.com/gulpjs/glob-parent/pull/53
server-timing: nginx;desc="NGINX";dur=0.585152,glb;desc="GLB";dur=101.328249
x-voltron-version: 321f992
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=3ec49xybd0ucmJrt4FWPeF5nU37IFhKamgEBdvrd%2BAQUs3ZyaDbAPBL9YhwvojR4M%2FBX9Dt%2B%2FNnDpbQK5HfK0PTny9uM3D1Z%2BrIBjCuHQD8fWv0kqDpbmmC1sqB6uFmxMQfKkc%2FiM8nEZ6cVz6MNEHoNePbNANPzOh8DlUHJMjPKaR05n2IJMjCNp4n3JaGvS8aszBV77PAdDBYz6gxuP%2Br%2FLgjjDZUUIJggHYXQStWZCk%2FgQ09YSweEBYJJt83C4FsAYx1IzPrKRH22YyTfBQ%3D%3D--XSel%2B5RpAHA9mowP--qxuuFsqe7Hov69ZsAeklBg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1223142258.1753916462; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 23:01:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 23:01:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B8AC:373DAE:A52AB:F565E:688AA42E
HTTP/2 200
date: Wed, 30 Jul 2025 23:01:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=402.597508,conversation_content-fragment;desc="conversation_content fragment";dur=1071.297466,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=352.915779,nginx;desc="NGINX";dur=0.99656,glb;desc="GLB";dur=101.1146
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B8AC:373DAE:A52DA:F5693:688AA42E
fix: performance improvement by Trott · Pull Request #53 · gulpjs/glob-parent · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 45
fix: performance improvement #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are failing because performance with the newly-added test is not good enough without the additional help of the |
phated
reviewed
Sep 29, 2021
| if (/[^\\][{[]/.test(str)) { | ||
| return true; | ||
| } | ||
| return isGlob(str); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything weird (different?) by changing the order of the isGlob check and "globby" regexp test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because they were OR'ed, I don't think it makes any difference logically. I'm happy to flip it back assuming that doesn't introduce performance regressions.
|
@Trott can you update the package.json to require is-glob 4.0.3? 🍻 |
Done. |
|
All green! âś… |
phated
reviewed
Sep 29, 2021
|
Published as 6.0.2 - thanks a ton @Trott! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
The performance measuring here is confounded a bit by an
is-globperformance gotcha that is fixed in micromatch/is-glob#15. Here's what I'm seeing runningtime node -e "require('./')('/('.repeat(500000) + ')')"on my 2013 Macbook:(The added test will likely fail without the is-glob PR, depending on how performant the test machine is.)