Path to assets are wrong

  • Resolved Maxime Culea

    (@maximeculea)


    2 months ago

    Hello Share This team,

    In your code you don’t use the basics of WordPress development and especially you hardcoded a path like so: define( 'DIR_URL', '/wp-content/plugins/sharethis-share-buttons/' );

    Could you use dedicated WordPress existing variables instead declaring hard coded path, such: WP_CONTENT_DIR,WP_CONTENT_URL, WP_PLUGIN_DIR, WP_PLUGIN_URL, or use __DIR__ or even dirname( __FILE__ ) or even plugin_dir_path(), plugin_dir_url(), etc.
    Here the workarround is plugin_dir_url(__FILE__).

    Also, you validated another same topic (https://wordpress.org/support/topic/path-to-assets/), which indicates you will patch this issue. It seems not beeing the case during 6 months, for a 1-minute patch, this is not serious at all…

    Please be more active and consider updating your plugin to WordPress constraints. This breaks website sadly.

    Many thanks for your understanding, looking forward.

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author ShareThis

    (@sharethis)

    2 months ago

    Hi @maximeculea,

    Thank you for flagging this! We’ve released a fix for this in our latest version (2.3.7). Could you please update to this version and let us know if it resolves the issue on your end?

    Best,

    ShareThis Support

    Thread Starter Maxime Culea

    (@maximeculea)

    2 months ago

    Hello Share This team,

    Happy to see you fixed it quickly, it’s working! Many thanks for your quickness this time 🙂

    Thanks

Viewing 2 replies - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.