CARVIEW |
Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Editorial comments on the metadata document #679
Comments
iherman
added this to the
Proposed Rec
milestone
Jul 11, 2015
Comment on one point:
The problem is the implementation issues of SVG. While the original source of the file has, of course, the texts, if the generated SVG keeps the text than I could not secure proper display across all browsers. The issue seems to be, obviously, font plus the fact that the tools (AI in this case) insist on positioning each character separately (which makes it equally un-accessible I guess). SVG fonts or using WOFF leads to differences among implementations (or do not work at all as for SVG Fonts), relying on system fonts is also unreliable. Any good idea on how to handle this would be welcome, of course. |
iherman
added the
NonWG
label
Jul 11, 2015
More comments from timeless: https://www.w3.org/TR/2015/CR-csv2rdf-20150716/
I expected to see a table below, instead I ran into a NOTE. Move the
contents the => contents of the
occur/encountered is an odd mix
there's a remarks column, and most of this text probably belongs in it...
drop
any other datatype => a datatype other
you don't usually write
the provision of => providing
drop the
and new => and a new
missing
I kind of expected
you're missing an
why isn't
this is hard to read without styling, please consider using "carview.php?tsp="s around
provided => provided by
such a => such ???
missing
missing
|
gkellogg
self-assigned this
Jul 17, 2015
Mote comments from timeless: https://www.w3.org/TR/2015/CR-csv2json-20150716/
See earlier feedback [1] on en-gb/en-us
Hopefully feedback [1][2][3] I've sent previously can be applied to
note that in this document,
as => as an
missing
If N occurs once with value [1,2] and once with value [3,4], is the
missing
the trees => trees
any => another
insert
insert
drop
How is this relevant to a document about JSON?
were? are? |
gkellogg
assigned 6a6d74 and unassigned gkellogg
Jul 17, 2015
iherman
added CSV to JSON mapping CSV to RDF mapping
labels
Jul 25, 2015
To follow up on my previous note, I have added a longdesc file to describe the property diagram, taking care of one of the (sub-)issues. |
6a6d74
added a commit
to 6a6d74/csvw
that referenced
this issue
Oct 13, 2015
|
6a6d74 |
editorial changes arising from #679
|
a91ce2f
|
6a6d74
added a commit
to 6a6d74/csvw
that referenced
this issue
Oct 13, 2015
|
6a6d74 |
second batch of editorial changes to csv2rdf
… arising from ISSUE #679 |
c653712
|
6a6d74
added a commit
to 6a6d74/csvw
that referenced
this issue
Oct 13, 2015
|
6a6d74 |
editorial changes to csv2json arising from #679
|
621da6d
|
iherman commentedJul 11, 2015
(This is a transfer of the comments sent by 'timeless' to public-csv-wg-comments@w3.org')
W3C Editor's Draft 10 July 2015 [1]
GitHub
pattern:
Could you write "und" instead of und (unquoted)? For those of us
reading the document with a Screen Reader or similar tool (actually a
plain text serializer in my case), the monospace formatting is lost.
en-US:
please see point 2 of [2]
Google says it's two words.
This is the first instance of the group, but it isn't linked here
(it's linked in the next paragraph). That feels like putting the cart
before the horse.
Also, if you're going to mention the charter, you could do everyone
the favor of linking to it.
I object to capitalizing
Formats
.I don't think that word should be capitalized in this context.
Depending on how you parse the previous lines, this either references
2/2 or 2/3.
I'm not quite sure the value of writing this as you did. I'd suggest
"This document addresses the charter scope for {}. Additional charter
scope items include {} and {} which would be covered by other
documents."
missing
:
Here, the brackets are included in the link, they aren't in the document.
=> MUST generate a warning and use that default value.
which parallels this:
these items are not sentences and aren't preceded by a
:
"an"
are
=> that are | {empty}add
,
or:
?Offhand, figure 1 [3] was generated at a resolution which is too small
to read at 100%; text runs together... Also, the gray background is
unhelpful.
figure 1 [4] isn't accessible, it's just a bunch of lines / polylines.
Someone helpfully stripped all the words from the source code.
these aren't sentences...
... are ... are <- yuck
most of these don't end in a period:
except this one:
I couldn't follow this example. Partially, I think you hid the input
as prose and only showed output in example 11, whereas example 10 was
the input and the prose held the output.
pattern:
will
isn't an rfc wordNo Oxford Comma:
Oxford Comma:
please pick a style (I'd recommend Oxford).
I think you want to drop the
,
;the sentence is too long.
missing
.
isn't
taking a single value
redundant forboolean
?an
pattern:
of => over
but this is not an error
doesn't make sense / read wellpattern:
A -- note that you use
a URI
elsewhere, including later in this fragment.I'd suggest writing this as: "carview.php?tsp="carview.php?tsp=" or '"'
pattern:
A --
This second "sentence" needs more words.
It probably should be
to "false"
also...Is that an "Error", or just "whatever"?
the order of
or
s doesn't work.try ... neither string/string subtype nor a binary type.
stray
.
inside the parenthetical[1] https://w3c.github.io/csvw/metadata/
[2] https://lists.w3.org/Archives/Public/public-csv-wg-comments/2015Jun/0002.html
[3] https://w3c.github.io/csvw/metadata/properties.png
[4] https://w3c.github.io/csvw/metadata/properties.svg