Whoops, fixed in 3e27549 :)

Mark,

In merge of method name in dbo_source.php has duplicated code. At the beginning of the method is tested twice if is object or *. The duplicate test of * was removed in commit 7075aa5, but the test object continues.

The ternary operator "?:" can be used in this fashion only PHP 5.3 onwards, so please change it to the traditional (expr1) ? (expr2) : (expr3) format.

Lorenzo, in function name you cached only data that not passed in pregs. I did a commit to put in cache all names in string (most used): https://github.com/jrbasso/cakephp1x/commit/cd6aea04e76034a812742f6a79b5bb63dfd0417b

Very nice this changes! Congratulations.

Good catch ;) Fixed in 7a655f7

Mark,
In your skipIf of the new test you write wrong the function name (right is memory_get_usage and no get_memory_usage) and need negate the function_exists or use skipUnless.

I make the patch in commit jrbasso/cakephp1x@58af9e3. The tests run nice and cut about 0.01 second (~4%, but only has 3 tests involving the diff).

Well, I have not tested if it is faster, but in that case it is a bit difficult to decide when to stop looping since next could return false in the case there are no more elements, or if the next element is in fact false!

If you have any patch for this I'm interested in seeing it :)

Thanks again for your interest

I think #91 is referencing the old chaw tickets.

Are you sure that it's fix ticket #91? Ticket #91 has fixed in commit 259b59c.

Other thing: Instead use each/list in while statement, use current() with next(). Increase 30% of performance.

Taking it was a commit optimization: in preg of string.* in name method I put one explode that no needed. Can you remove? Thanks.

Right. Enhancement to Cake 2.x... :)

I considered doing that, but it broke some tests. Maybe we should consider that later. I'm not really sure if someone is relying on that fuzzy comparison in his app.

Lorenzo, in comparation of while you can use === unless ==. It's more realist (ex.: diff false than 0 or other empty value) and is more faster.

Hmmm, no problems.

I usually don't use i18n calls in the test suite as it can require additional classes to be loaded.

You forgot the internationalization in this commit. :)

I ment $clas variable (single s only, second parameter for addObject())