elcgit / s3-swf-upload-plugin

This is easy to test: just press the "Upload" link without selecting a file: you will get the "Succesfully uploaded" dialog if you have that callback installed.

I think the fix is as appended.

If only I could figure out how to recompile this to try it!

diff --git a/s3_upload.mxml b/s3_upload.mxml
index f351612..0295057 100644
--- a/s3_upload.mxml +++ b/s3_upload.mxml @@ -57,8 +57,8 @@

            // return if user not selected any file
            if (options.FileSize == null) {

•             trace(options.onSuccessCall);
  

•             ExternalInterface.call(options.onSuccessCall);
  

•             trace(options.onFailedCall);
  

•             ExternalInterface.call(options.onFailedCall);
              return;
          }
  

onSuccessCall

... this means that the onSuccess callback should pass the file name.

I think the fix is as appended. If only I could figure out how to recompile to try this out!

diff --git a/s3_upload.mxml b/s3_upload.mxml
index 0295057..01ce6b9 100644
--- a/s3_upload.mxml +++ b/s3_upload.mxml @@ -143,7 +143,7 @@

                selectButton.enabled = true;
                textInput.text = "Upload complete!";
                trace(options.onSuccessCall);

•             ExternalInterface.call(options.onSuccessCall);
  

•             ExternalInterface.call(options.onSuccessCall, options.FileName, options.FileSize);
              trace(event);
          });
  

... and it's clear that Event.OPEN listener is not firing, none of the actions in that function are ever activated.

I can't figure out what is making this all so flakey :S

When the user presses "submit", the flash issues a request
to the application s3_uploads_controller.

If the controller doesn't respond as expected with XML for the access - for example,
if instead it issues a redirect due to authorisation failture - then the flash script hangs.

The user will not see the "unauthorised access" page be rendered, they are left with
no feedback about what went wrong.

It seems this would need to be rectified with a failure callback on the URLLoader that issues the request ... at the moment there is no provision for this to fail gracefully.

Meanwhile - developers beware: the s3_uploads_controller must be available for general access. Best to give it a skip_before_filter on any authorisation controls on your app.

my flash-fu sux - but it'd be awesome to fire the selected callback with filename and size, or even a hash with everything known about the file. calling with a hash would future protect the interface. anyone have any idea how hard this'd be?

What it says on the tin. I'm trying to roll my own non s3 swf_uploader which hits an api directly (Soundcloud.com). Unfortunately, when the 201 error is thrown, I do not receive the response data (URL for the target upload). How are you doing this? I'm a flash coder by day and don't actually see anyway to avoid the IO Error and receive the data. I also can't have Soundcloud send a 200 response.