That’s not the issue!
It just always returns an empty string. You’ll need to actually add the attribute to test for this (not sure how to add it though).

Actually, in one version of Opera (9.25, perhaps):
<pre><code>
<div title="foo" />
div.getAttribute(‘title’);
// -> ’’
div.title;
// -> ‘foo’
</code></pre>

This will always return true!!!

Sure – But, I’ll want you to review it ;)

Indeed, it’s right in there. I’d like to discuss the API for this a bit more:

• deep argument should be optional and default to false.
  <pre>
  clone: function(element, deep) {
  if (!(element = $(element))) return;
  deep = !!deep;
  var clone = element.cloneNode(deep);
  // ...
  </pre>
  
• there should be a simple way to remove id attributes. This can be done either by using a third argument as a boolean which would handle this:
  <pre>
  clone: function(element, deep, removeId) {
  if (!(element = $(element))) return;
  var clone = element.cloneNode(deep);
  clone._prototypeUID = void 0;
  if (removeId) clone.id = ’’;
  if (deep) {
  var descendants = Element.select(clone, ‘‘),
  i = descendants.length;
  while (i—) {
  descendants[i]._prototypeUID = void 0;
  if (removeId) descendants[i].id = ’’;
  }
  }
  return Element.extend(clone);
  }
  // API:
  $(element).clone(true, true);
  </pre>
  or by adding an optional callback which would receive the dom node as first and only argument.
  <pre>
  clone: function(element, deep, callback) {
  if (!(element = $(element))) return;
  var clone = element.cloneNode(deep);
  clone._prototypeUID = void 0;
  if (callback) callback(clone);
  if (deep) {
  var descendants = Element.select(clone, ‘‘),
  i = descendants.length;
  while (i—) {
  descendants[i]._prototypeUID = void 0;
  if (callback) callback(descendants[i]);
  }
  }
  return Element.extend(clone);
  }
  // API:
  $(element).clone(true, function(e) { e.id = ’’; });
  </pre>
  I think I finder the later more elegant and useful. Thoughts?

Thanks!

LGTM

I think we should target Safari 2.0.4 (that is, fully patched version of 2.0) which solves this problem altogether.

- Missing deprecation helper modifications

The actual code is missing, here.

This really would need tests.

I’m a bit uneasy about this feature test. We’re interested in making sure that the content attached to a script element is evaluated. Here we’re testing that it’s doesn’t throw an error. That’s very different, imho.

This is missing a test to verify Element#update correctly evaluates the content it is passed.

Could we possibly clean this up?
To something like this, maybe:
<pre><code>
for (var i = 0; element = elements[i]; i++) {
if (serializers[element.tagName.toLowerCase()])
arr.push(Element.extend(element));
}
return arr;
</code></pre>

The comment has since been removed.

The comment has since been removed.

That wouldn’t work, actually. you’d need to do:
<pre>if (Object.isUndefined(window.console)) return;</pre>
or:
<pre>if (typeof console === ‘undefined’) return;</pre>
Also, it might be worth returning earlier than that (at runtime, form example).
Thanks for your input.