CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/stleary/JSON-java/pull/675
HTTP/2 200
date: Wed, 23 Jul 2025 08:01:29 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=302.134834,conversation_content-fragment;desc="conversation_content fragment";dur=520.730016,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=214.487296,nginx;desc="NGINX";dur=1.475602,glb;desc="GLB";dur=100.355682
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=VlYvkHUEd0ehWumxRJpNEM5xF8TVLJFmZsriK7%2FEhIcBjaEkokoJddD%2F60N9qtWRWtspi63ue3hoJXZQ1q5wW4yKnJgvMM0rixxDUU8hhEftTUmFE%2FmB7pNrBtzExsSzgvrJFX7BYY8KCG%2Bnn4p4fa5wtksNTOU1g4bAweiZ7CGUVLR1SDLZGJApfg8BPM1S7WElJVfj9pU7PvvrGPyc5HjyrURVdzq5oAE8KoSYgxfiV%2BAPlqQBr2Opaug9f2P9Fu3CT6Qwt%2FBIgaAZ%2FsOiQg%3D%3D--CtSsn2A%2FpXtiphF5--Gg6jl8D7yjPL4%2Ff9F9CH8w%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1379969243.1753257688; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 08:01:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 08:01:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E192:35EBF4:6B9178:864632:688096D8
Updates value error messages to be consistent. by johnjaylward Β· Pull Request #675 Β· stleary/JSON-java Β· GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Updates value error messages to be consistent. #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stleary
merged 2 commits into
stleary:master
from
johnjaylward:Iss-649-better-error-message
Mar 25, 2022
Merged
Updates value error messages to be consistent. #675
stleary
merged 2 commits into
stleary:master
from
johnjaylward:Iss-649-better-error-message
Mar 25, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide both the type and value that failed conversion. Tries not to "toString" large value types like Arrays or Maps. For those types it will just output the type and not a value.
Thanks @johnjaylward starting 3 day comment window. |
gcf-merge-on-green bot
referenced
this pull request
in googleapis/java-spanner
Sep 29, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.json:json](https://togithub.com/douglascrockford/JSON-java) | `20220320` -> `20220924` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>douglascrockford/JSON-java</summary> ### [`v20220924`](https://togithub.com/stleary/JSON-java/releases/tag/20220924) [Compare Source](https://togithub.com/douglascrockford/JSON-java/compare/20220320...20220924) | Pull Request | Description | |---------------|--------------| | [#​688](https://togithub.com/douglascrockford/JSON-java/issues/688) | Update copyright to Public Domain | | [#​687](https://togithub.com/douglascrockford/JSON-java/issues/687) | Fix a typo | | [#​685](https://togithub.com/douglascrockford/JSON-java/issues/685) | JSONObject map type unit tests | | [#​684](https://togithub.com/douglascrockford/JSON-java/issues/684) | Remove v7 build from pipeline | | [#​682](https://togithub.com/douglascrockford/JSON-java/issues/682) | JSONString similarity | | [#​675](https://togithub.com/douglascrockford/JSON-java/issues/675) | [https://github.com/stleary/JSON-java/pull/675](https://togithub.com/stleary/JSON-java/pull/675) | </details> --- ### Configuration π **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDEuMyIsInVwZGF0ZWRJblZlciI6IjMyLjIwMS4zIn0=-->
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Fixes #649
What problem does this code solve?
Updates value error messages to be consistent. Some errors would output value information, but others not.
Provide both the type and value that failed conversion. Tries not to
"toString" large value types like Arrays or Maps. For those types it
will just output the type and not a value.
Risks
Low
Changes to the API?
No
Will this require a new release?
Yes
Should the documentation be updated?
No
Does it break the unit tests?
Yes. Some tests that verify error messages have been updated.
Was any code refactored in this commit?
Private methods were removed that allowed generation of the error messages with no value information.
Review status
APPROVED