| CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/open-telemetry/opentelemetry-java/pull/6725
HTTP/2 200
date: Thu, 24 Jul 2025 06:04:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=297.477909,conversation_content-fragment;desc="conversation_content fragment";dur=596.747084,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=391.986365,nginx;desc="NGINX";dur=0.7178,glb;desc="GLB";dur=101.542883
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=6s9pm880Zye0Xqpstsbh2Oc4bMVMlSjm%2FTyZubCLt5W22yLSAVsg8uETSGNCIx7AlgDkHHLvs08FfI77hzdWrOouYvcYNRth0ElJabjaIDokJ%2BgBhBhWZRrptJEs9Rs1fvC5WrUUNkvlICx0niCoerQUHZIDWX5nucGmDbFHbc0TAa%2BOXQDXcelrNoKuSjjX6fXnoN8WHezY9piLsGHH4Pk%2B0PGTmpPhMFTIOjVhZlkVNQUqRzVvwWS2o1HpEIIxE3gPtlACAzV4Xq7K1Xx2Og%3D%3D--XZTY3PHBD28F6kok--AVmk4WgkhzjxDicLivmA0Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.766038528.1753337079; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 06:04:39 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 24 Jul 2026 06:04:39 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A594:9C104:479EC3:5DDA9A:6881CCF6
Use autoconfigured ClassLoader to load declarative config by jack-berg · Pull Request #6725 · open-telemetry/opentelemetry-java · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 901
Use autoconfigured ClassLoader to load declarative config #6725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jack-berg
merged 3 commits into
open-telemetry:main
from
jack-berg:declarative-config-agent-support
Sep 20, 2024
Merged
Use autoconfigured ClassLoader to load declarative config #6725
jack-berg
merged 3 commits into
open-telemetry:main
from
jack-berg:declarative-config-agent-support
Sep 20, 2024
+84
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6725 +/- ##
=========================================
Coverage 90.06% 90.06%
- Complexity 6457 6463 +6
=========================================
Files 718 718
Lines 19511 19528 +17
Branches 1922 1923 +1
=========================================
+ Hits 17572 17588 +16
Misses 1350 1350
- Partials 589 590 +1 ☔ View full report in Codecov by Sentry. |
jack-berg
commented
Sep 16, 2024
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Sep 16, 2024
...tor/src/main/java/io/opentelemetry/sdk/extension/incubator/fileconfig/FileConfiguration.java
Show resolved
Hide resolved
…y-java into declarative-config-agent-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Agent extensions aren't currently able to provide declarative configuration
ComponentProviderSPI implementations because the agent requires a them to be loaded using a particular class loader.This adds a new
FileConfiguration#createoverload which allowsSpiHelper(which is based on aClassLoader) to be specified, and updatesAutoConfiguredOpenTelemetrySdkBuilderto call this new method.