| CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/github/codeql-action/pull/2938
HTTP/2 200
date: Sat, 11 Oct 2025 18:49:23 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=732.563025,conversation_content-fragment;desc="conversation_content fragment";dur=1168.985816,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=500.636229,nginx;desc="NGINX";dur=1.010314,glb;desc="GLB";dur=140.350314
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=nIOlt4HfUm8y3cMlSuK7xQ3Ljm%2FK8rqMdF%2FOvmEUYKCqKB7abjhryyOuz9w%2Fdq%2FFrmq0odpBjEE3qT26J1ZTJEP9Kr4uZ8ikyWXWp3CTARDI386Izrd6OUdS2j7Yc%2BIBmVJhe1i30irUiI3BMKypxHhZrchzV67%2FYu49jO0SBo1meLVgFfWYZoN5EF2oa%2FXxd5wScVfyzbfDpjuwsWWCE28K9g8chJ3WpLkYA4OSEwfl4UUqx5D6%2FjsvneSY%2FMnOiCzSb9dYDes4nA3z%2BfTKWA%3D%3D--ui4xBJMPVX8hzujl--km8La3SPABBmOXq%2FD6vI%2Fg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1853854062.1760208562; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 18:49:22 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 18:49:22 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CB0A:AD439:95C16A:C4A588:68EAA6B2
Keep user-provided query filters first by cklin · Pull Request #2938 · github/codeql-action · GitHub
cklin
force-pushed
the
cklin/default-query-filters
branch
from
June 19, 2025 19:20
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 402
Keep user-provided query filters first #2938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using defaultAugmentationProperties to generated expected test output eliminates the need to change individual tests when we add a new field to AugmentationProperties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ensures that user-defined query filters are applied before any automatically added exclusions, fixing a bug where user “include” filters were overridden.
- Renamed
defaultQueryFilterstoextraQueryExclusionsacross the config API. - Updated
calculateAugmentationandgenerateCodeScanningConfigto use the new property and preserve user filter ordering. - Adjusted tests, generated JS files, and the changelog to match the renaming and logic changes.
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/config-utils.ts | Renamed property and updated augmentation logic. |
| src/config-utils.test.ts | Simplified test fixtures by spreading defaultAugmentationProperties. |
| src/codeql.ts | reordered query-filters array and added explanatory comment. |
| src/codeql.test.ts | Imported and used defaultAugmentationProperties in tests. |
| lib/config-utils.js | Propagated renaming and logic updates to compiled output. |
| lib/codeql.js | Updated filter ordering logic and comments in compiled output. |
| CHANGELOG.md | Added release note for the bug fix. |
Comments suppressed due to low confidence (1)
src/codeql.ts:1273
- Add a unit test that verifies user-provided query filters appear before extra query exclusions in the generated CodeQL configuration.
...(augmentedConfig["query-filters"] || []),
This commit renames AugmentationProperties.defaultQueryFilters to extraQueryExclusions, and changes its type to ExcludeQueryFilter[]. It matters whether we are adding query inclusions or exclusions, and this renaming makes that distinction clearer.
cklin
force-pushed
the
cklin/default-query-filters
branch
from
1b923a3 to
65abb79
Compare
aeisenberg
approved these changes
Jun 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. This makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This PR fixes a bug in PR analysis where user-provided
includequery filter fails to exclude non-included queries.Merge / deployment checklist