| CARVIEW |
Select Language
HTTP/2 301
content-length: 0
location: https://github.com/eslint/rewrite/issues/240
HTTP/2 302
date: Sat, 11 Oct 2025 14:18:41 GMT
content-length: 0
location: https://github.com/eslint/rewrite/pull/240
server-timing: nginx;desc="NGINX";dur=0.804035,glb;desc="GLB";dur=138.870036
x-voltron-version: aab62e3
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=rOueKQaWhgiAR5vxAfG2699CE8uZClUCSOJYFymE0EkLsyqgo8e8%2F%2BPcGuBKvjbJW0UblOFv32WOU0jRCH5%2B8b3UUunx3OaDplRodCO2Q0FlWdE2%2BdkdoVfIdQy1D95mQEzJBwa3L4WWgfYGJFkUSghQHXJVrv8%2BQniD5wVbtzTSuuTuf9Vj8qPhsGD1BZ1o3E%2FVc9N6rOZJ7LWEs5jKG27IKmWjJRYFyhJwKepkCJ6llakt%2F04blg08HMebTQyNpQHPEYhD%2B%2BYTsjC4CZtw2g%3D%3D--nHcYeviBUoq117fy--tGsziZH2nT2YTHjT5mVSmw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.39846998.1760192321; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 14:18:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 14:18:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E82:14CD9D:788777:9EBE3D:68EA6741
HTTP/2 200
date: Sat, 11 Oct 2025 14:18:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=276.322901,conversation_content-fragment;desc="conversation_content fragment";dur=952.617198,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=306.024232,nginx;desc="NGINX";dur=0.502061,glb;desc="GLB";dur=138.04408
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9E82:14CD9D:7887B9:9EBE8A:68EA6741
fix: potential quadratic runtime in regular expression by ericcornelissen · Pull Request #240 · eslint/rewrite · GitHub
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 29
fix: potential quadratic runtime in regular expression #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Thanks for the pull request @ericcornelissen. Could you also add a unit test to packages/plugin-kit/tests/config-comment-parser.test.js to show that the problem has been fixed? Mocha tests timeout with an error after 2 seconds, so in this case it's sufficient to no copy-paste the repro code into a new test to verify that no timeout occurs. |
Improve a regular expression in the plugin-kit package that could lead match in quadratic runtime for certain strings.
|
Updated, without the patch this test takes ~10s for me and therefor fails due to the 2s timeout (unfortunately because it's blocking the test is not killed after 2s). |
1 task
fasttime
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Merged
1 task
nzakas
pushed a commit
that referenced
this pull request
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Prerequisites checklist
What is the purpose of this pull request?
Improve regular expressions in this repository that could match with unexpected overhead for certain strings.
What changes did you make? (Give an overview)
I improved a regular expression in the plugin-kit package that could match in quadratic runtime for certain strings. I did not find any other regular expressions in the source code of this repository that could have this kind of impact.
Related Issues
n/a
Is there anything you'd like reviewers to focus on?
no