You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @llenodo thanks for the PR, can you get CI passing and I'll be happy to merge these in. Looks like it just needs the specs to have the updated names.
Do you know if this is a change with a later activesupport? Trying to decide if we should restrict on anything with this change since older versions of something will still try the lowercase version.
Tests are passing now, ran into some issues with JsonIodocsWriter so changed the name back. Could be due to different version of activesupport in the code here vs my project (rails 5.1)
For me json_writer.classify returns JsonWriter - tested both on Rails 5.1 and 5.2. When tried to use rspec_api_documentation from master now I have an error uninitialized constant RspecApiDocumentation::Writers::JsonWriter.
I think this PR should be reverted and problem investigated with more details.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the docs:generate command I was getting the following error:
Turned out to be this line in
RspecApiDocumentation::ApiDocumentation
:apparently
"json_writer".classify
is now returningJSONWriter
instead ofJsonWriter
, thus giving the uninitialized constant error