You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This versioning scheme communicates that all rspec versions greater than or equal to 3.0 are supported, by rspec 4 is not. This make sense, sense there is no rspec 4. This change effectively does nothing, but future-proofs us when rspec 4 is released.
We're already protected by the rspec 4 upgrade with what we have. The extra >= 3.0.0 is just to specific the minimum version inside of the tilde we support. Creating the gem via gem build brings up warnings unless that is there.
I was just going off what gem build said. Here is how it's complaining about activesupport
WARNING: open-ended dependency on activesupport (>= 3.0.0) is not recommended
if activesupport is semantically versioned, use:
add_runtime_dependency 'activesupport', '~> 3.0', '>= 3.0.0'
I removed the >= 3.0.0 from the rspec line and it's not complaining any more. We can merge once the build passes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This versioning scheme communicates that all rspec versions greater than or equal to 3.0 are supported, by rspec 4 is not. This make sense, sense there is no rspec 4. This change effectively does nothing, but future-proofs us when rspec 4 is released.