Supports non ascii characters in example description and resource name

hanachin · hanachin · commit 7b3437a09bfc · 2014-06-12T01:24:58.000+09:00
diff --git a/lib/rspec_api_documentation/views/markup_example.rb b/lib/rspec_api_documentation/views/markup_example.rb
@@ -19,11 +19,11 @@ def respond_to?(method, include_private = false)
       end
 
       def dirname
-        resource_name.downcase.gsub(/[^0-9a-z.\-]+/, '_')
+        resource_name.downcase.gsub(/\s+/, '_')
       end
 
       def filename
-        basename = description.downcase.gsub(/\s+/, '_').gsub(/[^a-z_]/, '')
+        basename = description.downcase.gsub(/\s+/, '_').gsub(Pathname::SEPARATOR_PAT, '')
         basename = Digest::MD5.new.update(description).to_s if basename.blank?
         "#{basename}.#{extension}"
       end
diff --git a/lib/rspec_api_documentation/writers/json_writer.rb b/lib/rspec_api_documentation/writers/json_writer.rb
@@ -78,7 +78,7 @@ def dirname
       end
 
       def filename
-        basename = description.downcase.gsub(/\s+/, '_').gsub(/[^a-z_]/, '')
+        basename = description.downcase.gsub(/\s+/, '_').gsub(Pathname::SEPARATOR_PAT, '')
         "#{basename}.json"
       end
 
diff --git a/spec/views/html_example_spec.rb b/spec/views/html_example_spec.rb
@@ -13,12 +13,11 @@
   end
 
   describe "multi charctor example name" do
-    let(:label) { "コーヒーが順番で並んでいること" }
+    let(:label) { "Coffee / Teaが順番で並んでいること" }
     let(:example) { group.example(label) {} }
 
     it "should have downcased filename" do
-      filename = Digest::MD5.new.update(label).to_s
-      expect(html_example.filename).to eq(filename + ".html")
+      expect(html_example.filename).to eq("coffee__teaが順番で並んでいること.html")
     end
   end
 end
diff --git a/spec/writers/json_example_spec.rb b/spec/writers/json_example_spec.rb
@@ -0,0 +1,12 @@
+# -*- coding: utf-8 -*-
+require 'spec_helper'
+
+describe RspecApiDocumentation::Writers::JsonExample do
+  let(:configuration) { RspecApiDocumentation::Configuration.new }
+
+  describe '#filename' do
+    specify 'Hello!/ 世界' do |example|
+      expect(described_class.new(example, configuration).filename).to eq("hello!_世界.json")
+    end
+  end
+end
