fix(display): Update display import (#1709)

walterdiaza · fabclmnt · web-flow · commit f593bb7bde88 · 2025-03-04T11:23:26.000-08:00
* fix: improve type checking logic in _is_cast_type_defined function * fix: update IPython import paths to use the correct module * Revert "fix: improve type checking logic in _is_cast_type_defined function" This reverts commit 65e424c. --------- Co-authored-by: Fabiana <fabiana.clemente@ydata.ai>
diff --git a/src/ydata_profiling/profile_report.py b/src/ydata_profiling/profile_report.py
@@ -509,7 +509,7 @@ def to_notebook_iframe(self) -> None:
         Notes:
             This constructions solves problems with conflicting stylesheets and navigation links.
         """
-        from IPython.core.display import display
+        from IPython.display import display
 
         from ydata_profiling.report.presentation.flavours.widget.notebook import (
             get_notebook_iframe,
@@ -532,7 +532,7 @@ def to_widgets(self) -> None:
         except ModuleNotFoundError:
             pass
 
-        from IPython.core.display import display
+        from IPython.display import display
 
         display(self.widgets)
 
diff --git a/src/ydata_profiling/report/presentation/flavours/widget/correlation_table.py b/src/ydata_profiling/report/presentation/flavours/widget/correlation_table.py
@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.correlation_table import CorrelationTable
diff --git a/src/ydata_profiling/report/presentation/flavours/widget/duplicate.py b/src/ydata_profiling/report/presentation/flavours/widget/duplicate.py
@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.duplicate import Duplicate
diff --git a/src/ydata_profiling/report/presentation/flavours/widget/notebook.py b/src/ydata_profiling/report/presentation/flavours/widget/notebook.py
@@ -5,7 +5,7 @@
 from typing import TYPE_CHECKING, Union
 
 if TYPE_CHECKING:
-    from IPython.core.display import HTML
+    from IPython.display import HTML
     from IPython.lib.display import IFrame
 
 from ydata_profiling import ProfileReport
@@ -22,7 +22,7 @@ def get_notebook_iframe_srcdoc(config: Settings, profile: ProfileReport) -> "HTM
     Returns:
         IPython HTML object.
     """
-    from IPython.core.display import HTML
+    from IPython.display import HTML
 
     width = config.notebook.iframe.width
     height = config.notebook.iframe.height
diff --git a/src/ydata_profiling/report/presentation/flavours/widget/sample.py b/src/ydata_profiling/report/presentation/flavours/widget/sample.py
@@ -1,4 +1,4 @@
-from IPython.core.display import display
+from IPython.display import display
 from ipywidgets import Output, widgets
 
 from ydata_profiling.report.presentation.core.sample import Sample
diff --git a/src/ydata_profiling/utils/notebook.py b/src/ydata_profiling/utils/notebook.py
@@ -3,6 +3,6 @@
 
 def full_width() -> None:
     """Resize the notebook to use it's full width"""
-    from IPython.core.display import HTML, display
+    from IPython.display import HTML, display
 
     display(HTML("<style>.container { width:100% !important; }</style>"))
diff --git a/tests/notebooks/meteorites.ipynb b/tests/notebooks/meteorites.ipynb
@@ -60,6 +60,13 @@
     "df = pd.concat([df, duplicates_to_add], ignore_index=True)"
    ]
   },
+  {
+   "cell_type": "code",
+   "execution_count": null,
+   "metadata": {},
+   "outputs": [],
+   "source": []
+  },
   {
    "cell_type": "code",
    "execution_count": null,
@@ -77,7 +84,7 @@
     "    display(pr)\n",
     "\n",
     "assert len(out.outputs) == 2\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\"\n",
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\"\n",
     "assert out.outputs[1].data[\"text/plain\"] == \"\""
    ]
   },
@@ -129,7 +136,7 @@
     "    display(pfr)\n",
     "\n",
     "assert len(out.outputs) == 2\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\"\n",
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\"\n",
     "assert out.outputs[1].data[\"text/plain\"] == \"\""
    ]
   }
diff --git a/tests/notebooks/titanic.ipynb b/tests/notebooks/titanic.ipynb
@@ -93,7 +93,7 @@
     "\n",
     "# assert len(out.outputs) == 2\n",
     "# assert out.outputs[0].data['text/plain'].startswith('Tab(children=(HTML(value=')\n",
-    "# assert out.outputs[1].data['text/plain'] == '<IPython.core.display.HTML object>'\n",
+    "# assert out.outputs[1].data['text/plain'] == '<IPython.display.HTML object>'\n",
     "# assert 'ydata-profiling' in out.outputs[1].data['text/html']"
    ]
   },
@@ -108,7 +108,7 @@
     "    profile.to_notebook_iframe()\n",
     "\n",
     "assert len(out.outputs) == 1\n",
-    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\""
+    "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\""
    ]
   }
  ],

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-from IPython.core.display import display`
	`1`	`+from IPython.display import display`
`2`	`2`	`from ipywidgets import Output, widgets`
`3`	`3`
`4`	`4`	`from ydata_profiling.report.presentation.core.correlation_table import CorrelationTable`
Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@`
`93`	`93`	`"\n",`
`94`	`94`	`"# assert len(out.outputs) == 2\n",`
`95`	`95`	`"# assert out.outputs[0].data['text/plain'].startswith('Tab(children=(HTML(value=')\n",`
`96`		`- "# assert out.outputs[1].data['text/plain'] == '<IPython.core.display.HTML object>'\n",`
	`96`	`+ "# assert out.outputs[1].data['text/plain'] == '<IPython.display.HTML object>'\n",`
`97`	`97`	`"# assert 'ydata-profiling' in out.outputs[1].data['text/html']"`
`98`	`98`	`]`
`99`	`99`	`},`
`@@ -108,7 +108,7 @@`
`108`	`108`	`" profile.to_notebook_iframe()\n",`
`109`	`109`	`"\n",`
`110`	`110`	`"assert len(out.outputs) == 1\n",`
`111`		`- "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.core.display.HTML object>\""`
	`111`	`+ "assert out.outputs[0].data[\"text/plain\"] == \"<IPython.display.HTML object>\""`
`112`	`112`	`]`
`113`	`113`	`}`
`114`	`114`	`],`