CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 02:35:43 GMT
content-length: 0
location: https://github.com/dotnet/macios/issues/21293
server-timing: nginx;desc="NGINX";dur=0.891903,glb;desc="GLB";dur=101.057986
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=NymvoiyY1NV5vcCLwQN09myrHU%2FGuVlfidgkdnIujYB6yJFP9M666ZvWRf%2BcMnAzxEHNI6SMhOudFWpOueOD2lKeAMjV32G8vR0%2FK5Y4pyi6uF4ulkLLGcYVgsP5CVAFCRrysjsC9y14jkveKZALvMJK1qd6hQaAR7Mqdv6P9ZWEyyYxJzzaVV6opXQYXpIPOiJjDhd0%2BRT8yZn5kwQOg32HdHFfkF2%2F5nC2nPsn6wgjqspJhi0yjtXNZb2cC5X8PD3hJ9hS7oNUGsKyp739jw%3D%3D--tYgMGnxoJIKRwasw--a1%2FMeyUhgYAI4axd86X%2FaQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.226519921.1753497343; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:35:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 02:35:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8976:138BF2:D00D1:1457AF:68843EFF
HTTP/2 200
date: Sat, 26 Jul 2025 02:35:44 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=191.827425,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=782.388757,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=48.23139,nginx;desc="NGINX";dur=1.235419,glb;desc="GLB";dur=101.296411
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8976:138BF2:D00E8:1457CA:68843EFF
Enable EnableTrimAnalyzer by default Β· Issue #21293 Β· dotnet/macios Β· GitHub
No typeNo projectsNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 543
Closed
Labels
enhancementThe issue or pull request is an enhancementThe issue or pull request is an enhancement
Milestone
Description
The idea is to set EnableTrimAnalyzers=true
by default in our targets somewhere, so that customers get trimmer warnings by default in all configurations (even if they've disabled linking in some configurations).
There are a few thoughts here:
- Our end goal is a fully trimmable world (100% trimmable won't happen, but we want to get as close as we can).
- Mobile projects have been trimmed for many years, and as such mobile developers are more accustomed to trimming than desktop developers. Mobile code base is also often more trimmable than desktop code, for the same reason.
- In theory we'd like the trim analyzers to only be enabled when the project trims in any configuration, but we can't reliably detect whether the trimmer is fully enabled (TrimMode=full) in any configuration, any logic to try to reason about this or compute an accurate value is bound to not work for someone, and as the complexity grows, it'll be harder to reason about when the trim analyzers are enabled.
So the proposal is to just set EnableTrimAnalyzers=true
by default.
- It's very simple.
- It's easy to override in a customer's project (set
EnableTrimAnalyzers=false
). - It hopefully moves us towards a fully trimmable world.
In order to minimize impact, we could enable it early on for .NET 10 to capture feedback. If it turns out too disruptive, we can also back the change out again (which is easy, because it's a very simple change).
dalexsotoivanpovazan
Metadata
Metadata
Assignees
Labels
enhancementThe issue or pull request is an enhancementThe issue or pull request is an enhancement
Type
Projects
Milestone
Relationships
Development
Issue actions
You canβt perform that action at this time.