You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using app bundles users install the application from an apkset.
At this time this only contains the base application. However we might
in the future support dynamic features in some fashion. In this case
developers should be able to pick which features they want installed.
This commit adds an AndroidInstallModules ItemGroup which will allow
developers to specify which modules to install. By default it will be
empty. This means all modules which are to be installed on first install
will be installed. So there is no change in the current behavior.
This commit also adds support for passing additional arguments to bundle tool via the new AndroidBundleToolExtraArgs property.
Some "public facing" documentation would be useful, not so much so that we can have something in Documentation, but more to validate that how this works is appropriate. (It'll become part of the commit message!)
For example, this approach involves using the @(AndroidInstallModules) item group. Item groups can't be specified on the command line. Is this a problem? Is there an expectation to be able to specify modules on a msbuild /t:Install command line, or is editing the .csproj the preferred experience?
@jonpryor currently this new AndroidInstallModules is not very useful. Its the beginning of a much larger piece of work outlined in #4810 (comment). I can document the new ItemGroup, but users will currently have no use for it since we need to do allot of the other stuff on the list at #4810 (comment) to make it useful.
…ets.
Context dotnet#4810
When using app bundles users install the application from an `apkset`.
At this time this only contains the base application. However we might
in the future support dynamic features in some fashion. In this case
developers should be able to pick which features they want installed.
This commit adds an `AndroidInstallModules` ItemGroup which will allow
developers to specify which modules to install. By default it will be
empty. This means all modules which are to be installed on first install
will be installed. So there is no change in the current behavior.
This commit also adds support for passing additional arguments to
`bundletool` via the new `$(AndroidBundleToolExtraArgs)` property.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context #4810
When using app bundles users install the application from an
apkset
.At this time this only contains the base application. However we might
in the future support dynamic features in some fashion. In this case
developers should be able to pick which features they want installed.
This commit adds an
AndroidInstallModules
ItemGroup which will allowdevelopers to specify which modules to install. By default it will be
empty. This means all modules which are to be installed on first install
will be installed. So there is no change in the current behavior.
This commit also adds support for passing additional arguments to
bundle tool
via the newAndroidBundleToolExtraArgs
property.