CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:55 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2975
server-timing: nginx;desc="NGINX";dur=1.346526,glb;desc="GLB";dur=101.413596
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=QYaQabR0hGFf9EYBW%2FiYshi7tbQbFcycWG0t92nVPIJFOG%2BdsjhYKJEsvcjDESuR1VNkYz7MFz7nXp83Z%2F5zGxUFYhJGiGAyCXSnHlO4qgfrPWtOuQy1QXrjPzKTytQ5UQzQTDK9o7ELlLyYp9e7ypklkRTcDk6mReUfYsbiQq0uk16RvAMi9Kr0VYlAbcDGoZNi9fWftIkcp5JrSQbhyxUUS7xElYGGnYg5FzHsmty%2BfHexshtsXod62mKmeqKKCyGeUtwHoWw3HPf3bLZpnw%3D%3D--ZdvpJ62ClQDsa6BV--8OxsTw%2Bfaw%2F4E6B8nUJf%2Bw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.662990684.1753519315; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DCEC:14DB91:3757BC:4A49DA:688494D3
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=264.02338,conversation_content-fragment;desc="conversation_content fragment";dur=360.003326,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=263.367796,nginx;desc="NGINX";dur=1.304894,glb;desc="GLB";dur=102.294913
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DCEC:14DB91:3757D9:4A49FD:688494D3
[Xamarin.Android.Build.Tasks] cache aapt2 version in AppDomain by jonathanpeppers · Pull Request #2975 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] cache aapt2 version in AppDomain #2975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have `$(AndroidUseAapt2)` set to `True` (which is also the default on master), the `<ResolveAndroidTooling/>` tooling task seems to take longer: aapt2: 83 ms ResolveAndroidTooling 2 calls aapt: 4 ms ResolveAndroidTooling 2 calls I figured out this was due to how we shell out to `aapt2 version` to check the version of `aapt2`. We should use `RegisterTaskObject` and cache the result of this call! * I used a key that contains the path to `aapt2`, so if that * I don't think we actually need to invalidate the cached value on anything else because we are shipping `aapt2` now. But what if there is a Xamarin.Android update? If you install a new VSIX, VS on Windows makes you restart the IDE. If you install a PKG on Mac, you need to restart the IDE *anyway*, because it keeps all system MSBuild `.targets` files in memory... Weird things will happen if you install a Xamarin.Android PKG on Mac and don't restart VS for Mac. After this change, when the `aapt2 version` call is cached: 2 ms ResolveAndroidTooling 2 calls This was the "Hello World" sample project in this repo.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
If you have
$(AndroidUseAapt2)
set toTrue
(which is also thedefault on master), the
<ResolveAndroidTooling/>
tooling task seemsto take longer:
I figured out this was due to how we shell out to
aapt2 version
tocheck the version of
aapt2
.We should use
RegisterTaskObject
and cache the result of this call!aapt2
, so if someone changes theaapt2
used, it should callaapt2 version
again.anything else because we are shipping
aapt2
now.But what if there is a Xamarin.Android update?
If you install a new VSIX, VS on Windows makes you restart the IDE. If
you install a PKG on Mac, you need to restart the IDE anyway,
because it keeps all system MSBuild
.targets
files in memory...Weird things will happen if you install a Xamarin.Android PKG on Mac
and don't restart VS for Mac.
After this change, when the
aapt2 version
call is cached:This was the "Hello World" sample project in this repo.