| CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:31 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2945
server-timing: nginx;desc="NGINX";dur=1.365973,glb;desc="GLB";dur=100.920974
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=hCqG7F38ty65vzF4FB06w41MNp8nlhmqltO9JHq9SqlTv4idSXJbwKBwlMW%2BTiFCmrKILn%2Fx6IdFPOM5Fw5hO4%2BzSgZUvoQYh1DhOAmOtqGk%2BWt0vLr%2FO4AaOAgd%2F0ByvhUmGgCv1%2BU5dyyq6b9%2FsHLH8Jy0nOvbZb4FVZYLDty8fEoGM4jPAxDMMYEiG0v2BgucR9kRtWGpzFRWL35H6x0LQI%2BV9EPZL%2BkuTPUV8rEaawEIReBvNV3kQ8Vqh%2Bj3A5Vt9ed4zj3epjEW5OOFMQ%3D%3D--u0LcS70copMWxUNa--Rsdsisr3iWNH1fErxAWLfg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.863300949.1753519291; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DBBA:15141D:D40AD:106883:688494BB
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=317.616909,conversation_content-fragment;desc="conversation_content fragment";dur=373.282747,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=231.027783,nginx;desc="NGINX";dur=0.808411,glb;desc="GLB";dur=100.594527
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DBBA:15141D:D40C8:1068B4:688494BB
[Xamarin.Android.Build.Tasks] _LinkAssembliesNoShrink inputs by jonathanpeppers · Pull Request #2945 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] _LinkAssembliesNoShrink inputs #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 5ec3e3a In 5ec3e3a, I used a new `@(_ResolvedUserMonoAndroidAssemblies)` item group to improve incremental build performance. Targets that only need to perform work with `MonoAndroid` assemblies, can be skipped unless a `MonoAndroid` assembly changes. We can use this same technique with the linker for builds with `LinkMode=None`. The only steps in this case are: if (options.LinkNone) { pipeline.AppendStep (new FixAbstractMethodsStep ()); pipeline.AppendStep (new OutputStep ()); return pipeline; } `FixAbstractMethodsStep` only applies to `MonoAndroid` assemblies, so we can use `@(_ResolvedUserMonoAndroidAssemblies)` to decide if `_LinkAssembliesNoShrink` can be skipped. For an incremental build with a XAML change, this target was taking: 424 ms LinkAssemblies 1 calls This was the Xamarin.Forms app in this repo. I would say this improves incremental build times by about 400ms for small apps.
|
There are unit test failures, some of which aren't due to the typical "transient network errors": https://jenkins.mono-project.com/job/xamarin-android-pr-pipeline-release/476/testReport/junit/Xamarin.Android.Build.Tests/BuildTest/BuildIncrementingClassName___Release/ |
|
After more thought (and looking at build logs), this change would break things.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Context: jonathanpeppers@5ec3e3a
In 5ec3e3a, I used a new
@(_ResolvedUserMonoAndroidAssemblies)itemgroup to improve incremental build performance. Targets that only need
to perform work with
MonoAndroidassemblies, can be skipped unless aMonoAndroidassembly changes.We can use this same technique with the linker for builds with
LinkMode=None. The only steps in this case are:FixAbstractMethodsSteponly applies toMonoAndroidassemblies, sowe can use
@(_ResolvedUserMonoAndroidAssemblies)to decide if_LinkAssembliesNoShrinkcan be skipped.For an incremental build with a XAML change, this target was taking:
This was the Xamarin.Forms app in this repo. I would say this improves
incremental build times by about 400ms for small apps.