CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:01 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2930
server-timing: nginx;desc="NGINX";dur=0.512991,glb;desc="GLB";dur=100.423916
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=8U6Ct7UmQrst76eUCY1Po%2BthVSKcRH9p8aUtagrugdjxLk0xV3X4YQ15MCB3LfdEDhqvlfjqT%2FjWsWOrXiwtGdrNllUMvlb2m2NZKHD%2FjAnPQGIg4RtfPiWYMauSI0NAbr0Ggqw9hFERYDxjMomfWUnvD0A4DUVDafgqHQga6kDbZJIc2OQMhmYXHFBJqh22Vyu87ooCLCs6VOotNKflkUaYxl09gD3erwVo6M6X40dudRFbDAe5fkPyNvosSv6eo1b5p%2FFqHPj1BxfoUThHvg%3D%3D--tmNIV5FfsaNdyhkH--L%2F8rBKVvGmCIUvGZFj1JBw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1853365197.1753519261; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D656:37D5F1:36C323:49ACF4:6884949D
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:02 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=290.285407,conversation_content-fragment;desc="conversation_content fragment";dur=621.315343,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=290.477023,nginx;desc="NGINX";dur=0.793221,glb;desc="GLB";dur=100.080333
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: D656:37D5F1:36C35B:49AD36:6884949D
[Xamarin.Android.Build.Tasks] <GetImportedLibraries/> perf improvements by jonathanpeppers · Pull Request #2930 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] <GetImportedLibraries/> perf improvements #2930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dellis1972
merged 2 commits into
dotnet:master
from
jonathanpeppers:getimportedlibraries
Apr 8, 2019
Merged
[Xamarin.Android.Build.Tasks] <GetImportedLibraries/> perf improvements #2930
dellis1972
merged 2 commits into
dotnet:master
from
jonathanpeppers:getimportedlibraries
Apr 8, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a target running on an incremental build with only a XAML code change: 116 ms _BuildLibraryImportsCache 1 calls This was using VS 2019 GA, just a blank Xamarin.Forms app. Reviewing `<GetImportedLibraries/>` it had some general perf improvements that could be done: * It called `Directory.EnumerateFiles` three times... * It used a bunch of LINQ where a `foreach` would do. Additionally, I saw some improvements I could do at the MSBuild target level: <Target Name="_BuildLibraryImportsCache" Inputs="$(MSBuildProjectFullPath);@(_ReferencePath);@(_ReferenceDependencyPaths);$(_AndroidBuildPropertiesCache);$(_AndroidLibraryProjectImportsCache)" Outputs="$(_AndroidLibraryImportsCache).stamp"> This target operates on the output of `_ResolveLibraryProjectImports`, but it was re-running if *any* assembly changed? I think the `Inputs` and `Outputs` would more appropriately be: Inputs="$(_AndroidLibraryProjectImportsCache)" Outputs="$(_AndroidStampDirectory)_BuildLibraryImportsCache.stamp" This way, if `_ResolveLibraryProjectImports` runs and does work, it writes to `$(_AndroidLibraryProjectImportsCache)`. We then only need to run this task when that file changes. I also updated this target so it follows our new convention for placing stamp files in `$(_AndroidStampDirectory)`. ~~ Results ~~ An example of an initial build of the Xamarin.Forms project in this repo: Before: 299 ms GetImportedLibraries 1 calls After: 172 ms GetImportedLibraries 1 calls And then an incremental build, that is a XAML change: Before: 109 ms _BuildLibraryImportsCache 1 calls After: n/a The task is skipped now: _BuildLibraryImportsCache: Skipping target "_BuildLibraryImportsCache" because all output files are up-to-date with respect to the input files. Overall, I would say there is a ~120ms improvement on initial build. Incremental builds with XAML changes have a ~100ms improvement.
Build logs: getimportedlibraries.zip |
dellis1972
reviewed
Apr 5, 2019
3 of the errors look like those weird ssl issues. One is this
not sure it is related though, |
dellis1972
approved these changes
Apr 8, 2019
I restarted the macOS build -- if we just had network failures would be OK, but the multi-dex tests failing to start were concerning. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
I noticed a target running on an incremental build with only a XAML
code change:
This was using VS 2019 GA, just a blank Xamarin.Forms app.
Reviewing
<GetImportedLibraries/>
it had some general perfimprovements that could be done:
Directory.EnumerateFiles
three times...foreach
would do.Additionally, I saw some improvements I could do at the MSBuild target
level:
This target operates on the output of
_ResolveLibraryProjectImports
,but it was re-running if any assembly changed?
I think the
Inputs
andOutputs
would more appropriately be:This way, if
_ResolveLibraryProjectImports
runs and does work, itwrites to
$(_AndroidLibraryProjectImportsCache)
. We then only needto run this task when that file changes.
I also updated this target so it follows our new convention for
placing stamp files in
$(_AndroidStampDirectory)
.Results
An example of an initial build of the Xamarin.Forms project in this
repo:
And then an incremental build, that is a XAML change:
The task is skipped now:
Overall, I would say there is a ~120ms improvement on initial build.
Incremental builds with XAML changes have a ~100ms improvement.