CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:44:29 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2540
server-timing: nginx;desc="NGINX";dur=1.250492,glb;desc="GLB";dur=101.279467
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=pOE9uN3YjejTDiMV9AWWpoG2XjZ6HGuBbDuFqjvt%2FY4REex%2Fb5YpPVc0vA9sIU9T%2BIkE2LCkdTM%2BODmCDZNrTCG2N9RDwlZKMf50BPYmaWMHWcKKjb5qbV95C6TQLss6VPdW0CyPbJmfahoOF3MarRjEO5igTB%2F3Oxq4dYzeKzGIwYtqO5EOWtQX7x1oYpGdOvGgI%2BKyDNpsKmlJ1i4mP%2FPLPEMgMNyhmp5vyglSh6dmEHtyc8YWg4yQ5MtnslDhXWQSGGkQ4LbicIPfFZd%2BFA%3D%3D--L%2Bli8CiVL5pL10Mp--VP6Q0EwvtXiqNrc5W4gRKw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.997782034.1753519469; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:44:29 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:44:29 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8DDE:3B05D7:3739F8:4A3F6A:6884956D
HTTP/2 200
date: Sat, 26 Jul 2025 08:44:30 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=327.769069,conversation_content-fragment;desc="conversation_content fragment";dur=458.76227,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=236.504178,nginx;desc="NGINX";dur=0.535957,glb;desc="GLB";dur=100.804004
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 8DDE:3B05D7:373A18:4A3F99:6884956D
[Xamarin.Android.Build.Tasks] ResolveLibraryProjectImports temp files by jonathanpeppers · Pull Request #2540 · dotnet/android · GitHub
jonathanpeppers
force-pushed
the
resolvelibraryprojectimports-tempfiles
branch
from
December 18, 2018 03:03
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] ResolveLibraryProjectImports temp files #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:resolvelibraryprojectimports-tempfiles
Dec 19, 2018
Merged
[Xamarin.Android.Build.Tasks] ResolveLibraryProjectImports temp files #2540
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:resolvelibraryprojectimports-tempfiles
Dec 19, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Dec 17, 2018
Not going to merge since we do not have any build system atm :/ |
build |
When reviewing `ResolveLibraryProjectImports`, I noticed a few things we could improve: 1. We are using `GetResourceData` to get the entire contents of a file as a `byte[]` and then writing to disk. 2. We are writing temporary zip files to disk, reading them to extract, then deleting them. The first thing I did was take advantage of the `GetResourceStream` method, so we could just do `stream.CopyTo(file)`. This prevents us from allocating big `byte[]` the size of each file. Next, I took advantage of `ZipArchive.Open (stream)` and `GetResourceStream` to avoid the need for creating temporary zip files. We can unzip directly from the `Stream` in memory. ~~ Results ~~ When timing these changes, I used the Xamarin.Forms integration project in this repo: Before 1. 1793 ms ResolveLibraryProjectImports 1 calls 2. 1780 ms ResolveLibraryProjectImports 1 calls 3. 1770 ms ResolveLibraryProjectImports 1 calls After 1. 1750 ms ResolveLibraryProjectImports 1 calls 2. 1740 ms ResolveLibraryProjectImports 1 calls 3. 1702 ms ResolveLibraryProjectImports 1 calls I would say the improvements here are around 50ms.
aeda0e2
to
bebb5ea
Compare
jonathanpeppers
added a commit
that referenced
this pull request
Jan 2, 2019
…#2540) When reviewing the `<ResolveLibraryProjectImports/>` task, I noticed a few things we could improve: 1. We are using `GetResourceData()` to get the entire contents of a file as a `byte[]` and then writing to disk. 2. We are writing temporary zip files to disk, reading them to extract, then deleting them. The first thing I did was take advantage of the `GetResourceStream()` method, so we could just do `stream.CopyTo(file)`. This prevents us from allocating big `byte[]` the size of each file. Next, I took advantage of `ZipArchive.Open(stream)` and `GetResourceStream()` to avoid the need for creating temporary zip files. We can unzip directly from the `Stream` in memory. ~~ Results ~~ When timing these changes, I used the Xamarin.Forms integration project in this repo: Before 1. 1793 ms ResolveLibraryProjectImports 1 calls 2. 1780 ms ResolveLibraryProjectImports 1 calls 3. 1770 ms ResolveLibraryProjectImports 1 calls After 1. 1750 ms ResolveLibraryProjectImports 1 calls 2. 1740 ms ResolveLibraryProjectImports 1 calls 3. 1702 ms ResolveLibraryProjectImports 1 calls I would say the improvements here are around 50ms.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When reviewing
ResolveLibraryProjectImports
, I noticed a few thingswe could improve:
GetResourceData
to get the entire contents of a fileas a
byte[]
and then writing to disk.then deleting them.
The first thing I did was take advantage of the
GetResourceStream
method, so we could just do
stream.CopyTo(file)
. This prevents usfrom allocating big
byte[]
the size of each file.Next, I took advantage of
ZipArchive.Open (stream)
andGetResourceStream
to avoid the need for creating temporary zipfiles. We can unzip directly from the
Stream
in memory.Results
When timing these changes, I used the Xamarin.Forms integration
project in this repo:
I would say the improvements here are around 50ms.