CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:42:42 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2367
server-timing: nginx;desc="NGINX";dur=1.084895,glb;desc="GLB";dur=101.707999
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=4nYiAnkb2jBWJ25D4nhH2CIVw2UHeSlQAni%2FOCQZRHHwadx3WHw7O01PMGT6ytr5ylJxJiXPp9Ccyr8NlhNBtQmz78xncedr5KcBC4nYuEEbRj6yXSNfVmEJYeqpwJywqwWZWa6CRIELiQJTnQzeow%2F7EEvyxWKOlbxtszHSM1FNYFh2Mni5yJv5m79Hf3VAtD0dcVxqTMQ5tHhPSxdPtqSn0LNNL9AMbkuSII6N8zm1k7b%2BpdXtXXUtwnje4jsXrWmPThj7C%2BCjw2ftumdFuQ%3D%3D--DYe1c5lki%2FrTnJLI--VJ6OGc%2Bam6Z9xx6yVKP9Eg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.358457997.1753519362; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:42:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:42:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B908:242CC6:373B55:4A33CE:68849502
HTTP/2 200
date: Sat, 26 Jul 2025 08:42:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=296.746704,conversation_content-fragment;desc="conversation_content fragment";dur=722.37362,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=358.637921,nginx;desc="NGINX";dur=1.118832,glb;desc="GLB";dur=101.413761
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B908:242CC6:373B75:4A33EA:68849502
[Xamarin.Android.Build.Tasks] aapt2, move ConvertResourcesCases to a new target by jonathanpeppers · Pull Request #2367 · dotnet/android · GitHub
jonathanpeppers
force-pushed
the
aapt2-convertresourcescases
branch
from
November 2, 2018 02:52
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] aapt2, move ConvertResourcesCases to a new target #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:aapt2-convertresourcescases
Nov 2, 2018
Merged
[Xamarin.Android.Build.Tasks] aapt2, move ConvertResourcesCases to a new target #2367
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:aapt2-convertresourcescases
Nov 2, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jonathanpeppers looks ok, do you have any data on how this effects the build times for Aapt2? |
dellis1972
approved these changes
Nov 1, 2018
jonpryor
reviewed
Nov 1, 2018
…new target Fixes: dotnet#2356 When `$(AndroidUseAapt2)=True`, if you look for a log entry of a file that is processed: Processing: C:\Users\myuser\Desktop\Git\xamarin-android\tests\Xamarin.Forms-Performance-Integration\Droid\obj\Debug\90\lp\22\jl\res\values\values.xml 10/30/2018 4:28:18 PM > 1/1/0001 12:00:00 AM You will see this repeated several times (9 in case of a Xamarin.Forms project). It turns out, since the `_CompileAndroidLibraryResources` target is batched, it is called once per item of `@(_LibraryResourceHashDirectories)`: <Target Name="_CompileAndroidLibraryResources" DependsOnTargets="_CollectLibraryResourceDirectories" Condition="'$(_AndroidUseAapt2)' == 'True'" Inputs="%(_LibraryResourceHashDirectories.FileFound)" Outputs="$(_AndroidLibraryFlatArchivesDirectory)%(_LibraryResourceHashDirectories.Hash).stamp"> ... <ConvertResourcesCases ... /> <Aapt2Compile ... /> ... </Target> It calls `ConvertResourcesCases` for each call, which is not ideal. `ConvertResourcesCases` operates on the whole tree of resources, so it really should just run once: *before* `<Aapt2Compile/>`. I think the fix here is: - Move `ConvertResourcesCases` to a new `_ConvertLibraryResourcesCases` target - The new target's `Inputs` should be `@(_LibraryResourceHashDirectories->'%(FileFound)')` and *not* batched. - The new target's `Outputs` should be a new stamp file following our new convention. - The new stamp file should also be used as `AndroidConversionFlagFile`. - `_CompileAndroidLibraryResources` now depends on `_ConvertLibraryResourcesCases`, and it should only run on the first batched instance of `_CompileAndroidLibraryResources`.
1f647ec
to
7dd8cf4
Compare
dellis1972
approved these changes
Nov 2, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes: #2356
When
$(AndroidUseAapt2)=True
, if you look for a log entry of a filethat is processed:
You will see this repeated several times (9 in case of a Xamarin.Forms
project).
It turns out, since the
_CompileAndroidLibraryResources
target isbatched, it is called once per item of
@(_LibraryResourceHashDirectories)
:It calls
ConvertResourcesCases
for each call, which is not ideal.ConvertResourcesCases
operates on the whole tree of resources, so itreally should just run once: before
<Aapt2Compile/>
.I think the fix here is:
ConvertResourcesCases
to a new_ConvertLibraryResourcesCases
targetInputs
should be@(_LibraryResourceHashDirectories->'%(FileFound)')
and not batched.Outputs
should be a new stamp file following ournew convention.
AndroidConversionFlagFile
._CompileAndroidLibraryResources
now depends on_ConvertLibraryResourcesCases
, and it should only run on the firstbatched instance of
_CompileAndroidLibraryResources
.