| CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:12 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2174
server-timing: nginx;desc="NGINX";dur=0.922876,glb;desc="GLB";dur=101.79098
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=B3tJ7qhw3sPz4rGQs%2BjtCO%2BDoeriiLA3m0qdaaVbZdWw1cb9izr4gul3VMFdJM7HpapegkVazq6NDGahS2D32nG0GNH1bVkHwBYu5bDREyd0R%2By0lrCn0Qa101mO3R5WmURoD3mCvu6QQY76mY9mG6TxC0k5dnpsaV7yLTOlGj1rRl6%2Fm2jQiqexw6YdkGyc6xqQBLGB8dYTe%2F4gMOsnN4bRzL0G17wJGaLjuW%2BoEhV40wkZsqUfOQZ154YaCF6wPBMBxNsUbZCG4%2BkDS%2Fmc4Q%3D%3D--WfpHIqeWPjTIZo%2Be--%2BadMjtehLveL%2BY8TaxL0mA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1156660028.1753519272; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E20A:1FA760:37B6B1:4AA325:688494A8
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=381.009159,conversation_content-fragment;desc="conversation_content fragment";dur=591.241917,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=274.484032,nginx;desc="NGINX";dur=0.805532,glb;desc="GLB";dur=102.245461
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: E20A:1FA760:37B6C7:4AA375:688494A8
[Xamarin.Android.Build.Tasks] combine CheckTargetFrameworks/ResolveAssemblies by jonathanpeppers · Pull Request #2174 · dotnet/android · GitHub
jonathanpeppers
force-pushed
the
checktargetframeworks-resolveassemblies
branch
from
September 11, 2018 18:24
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] combine CheckTargetFrameworks/ResolveAssemblies #2174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:checktargetframeworks-resolveassemblies
Sep 13, 2018
Merged
[Xamarin.Android.Build.Tasks] combine CheckTargetFrameworks/ResolveAssemblies #2174
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:checktargetframeworks-resolveassemblies
Sep 13, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Sep 11, 2018
|
This saves 77ms. We should mention the savings in the commit messages so I can do less math. :-) |
…semblies Context: https://gist.github.com/jonathanpeppers/a207a8828317460239a12a8b0cc918d7 When reviewing how many times we are using Mono.Cecil to open every assembly, it was happening 9 times! Unfortunately it is not as easy as just "caching" something, the simplest approach for now is to start combining functionality that are in multiple tasks right now. A simple first example is the `CheckTargetFrameworks` MSBuild task, which runs after the `Compile` and `ResolveAssemblies` MSBuild tasks. `CheckTargetFrameworks` has the job of emitting warnings about `[assembly: System.Runtime.Versioning.TargetFramework]`. We can easily do this work in `ResolveAssemblies` as it is already looping over all the assemblies' custom attributes for other reasons. Changes to make this happen: - Removed `CheckTargetFrameworks` and the `_CheckTargetFrameworks` target, adding the required `TargetFrameworkVersion` and `ProjectFile` properties to `ResolveAssemblies`. - Added a new `CheckAssemblyAttributes` where we can add to a `switch` statement for new attribute types in the future as needed. - Added a dictionary of `api_levels`, and copied over the logic from `CheckTargetFrameworks` Before: 105 ms CheckTargetFrameworks 1 calls 188 ms ResolveAssemblies 1 calls After: 216 ms ResolveAssemblies 1 calls I timed the `tests/Xamarin.Forms-Performance-Integration` project in this repository: a build with no changes. Since `CheckTargetFrameworks` is removed completely, we can avoid the time it was taking to open every assembly again. This saves around 77ms.
jonathanpeppers
force-pushed
the
checktargetframeworks-resolveassemblies
branch
from
dc0d04f to
8e54441
Compare
|
I updated the commit message, since the macOS build hadn't started yet. I also mentioned what project, and that it was a build with no changes. Build logs here: CheckTargetFrameworks.zip |
|
Weird build error. |
|
build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Context: https://gist.github.com/jonathanpeppers/a207a8828317460239a12a8b0cc918d7
When reviewing how many times we are using Mono.Cecil to open every
assembly, it was happening 9 times!
Unfortunately it is not as easy as just "caching" something, the
simplest approach for now is to start combining functionality that are
in multiple tasks right now.
A simple first example is the
CheckTargetFrameworksMSBuild task,which runs after the
CompileandResolveAssembliesMSBuild tasks.CheckTargetFrameworkshas the job of emitting warnings about[assembly: System.Runtime.Versioning.TargetFramework]. We can easilydo this work in
ResolveAssembliesas it is already looping over allthe assemblies' custom attributes for other reasons.
Changes to make this happen:
CheckTargetFrameworksand the_CheckTargetFrameworkstarget, adding the required
TargetFrameworkVersionandProjectFileproperties toResolveAssemblies.CheckAssemblyAttributeswhere we can add to aswitchstatement for new attribute types in the future as needed.
api_levels, and copied over the logic fromCheckTargetFrameworksBefore:
After:
I timed the
tests/Xamarin.Forms-Performance-Integrationproject inthis repository: a build with no changes.
Since
CheckTargetFrameworksis removed completely, we can avoid thetime it was taking to open every assembly again.
This saves around 77ms.