CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:42 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2148
server-timing: nginx;desc="NGINX";dur=0.938888,glb;desc="GLB";dur=101.207836
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=FGu4cnlaZpAuF6pdCO8rGB7OAPEx7G6zTPO%2B%2FfOHGSfxrem3dac%2BQtdiinf%2FOy1yfa8QHEq7VIX8qiTrqgyFKUtqFTBKi5WRHARVF3QnEv0foJF7Rj93XmA06brEHH1jkAwhq69tm78r6zh2l5EWH7rBFpYLLOsNj8BhdSPs4n4PzqGCMiwhlWn1SYA6VVbJRIh8zbmvNJUoW%2BC8bSsV4gGsmWLHEwqWoPxk0Q0zhMylYW8WCAPmsuAka6rMq1UgJeEiRhe0ziumbS1wx5dkCg%3D%3D--FLQq2dCX%2FH01KhkB--V1R8XoUJWcSzC1Mfd5HX%2Bw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1622845403.1753519302; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:42 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:42 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9E48:2CB2E7:3712B7:4A031F:688494C6
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:43 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=266.889587,conversation_content-fragment;desc="conversation_content fragment";dur=384.796409,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=271.043173,nginx;desc="NGINX";dur=1.36754,glb;desc="GLB";dur=101.112654
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: 9E48:2CB2E7:3712CF:4A0342:688494C6
[Xamarin.Android.Build.Tasks] should Dispose AssemblyDefinition by jonathanpeppers · Pull Request #2148 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] should Dispose AssemblyDefinition #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewing our codebase, we found a place where the `BuildApk` task was calling an overload for `MonoAndroidHelper.IsReferenceAssembly`. This presented two problems: 1. It was using the `InMemory` option 2. We were not calling `Dispose()`! Case No.1 was bad, since we basically load every assembly into memory! foreach (ITaskItem assembly in ResolvedUserAssemblies) { if (MonoAndroidHelper.IsReferenceAssembly (assembly.ItemSpec)) { //... foreach (ITaskItem assembly in ResolvedFrameworkAssemblies) { if (MonoAndroidHelper.IsReferenceAssembly (assembly.ItemSpec)) { Likewise, we need to call `Dispose` here, since a lock could be held on the file here on Windows. The changes here made `BuildApk` slower (and more correct!), but the overall build time better. Before: 5890 ms BuildApk 1 calls Time Elapsed 00:01:02.59 After: 6377 ms BuildApk 1 calls Time Elapsed 00:00:59.37 I think the `AssemblyDefinition` instances must have been getting cleaned up later in the build by the GC (if we were lucky), and also used *a lot* more memory. This would contribute to overall build time.
Logs here: AssemblyDefinitionDispose.zip |
StephaneDelcroix
approved these changes
Sep 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Reviewing our codebase, we found a place where the
BuildApk
task wascalling an overload for
MonoAndroidHelper.IsReferenceAssembly
.This presented two problems:
InMemory
optionDispose()
!Case No.1 was bad, since we basically load every assembly into memory!
Likewise, we need to call
Dispose
here, since a lock could be heldon the file here on Windows.
The changes here made
BuildApk
slower (and more correct!), but theoverall build time better.
Before:
After:
I think the
AssemblyDefinition
instances must have been gettingcleaned up later in the build by the GC (if we were lucky), and also
used a lot more memory. This would contribute to overall build time.