CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:42:56 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2131
server-timing: nginx;desc="NGINX";dur=1.448058,glb;desc="GLB";dur=101.110168
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=3bVjrL5wYpAdVSpVmxplm408hgzDmChk%2Btgi69%2BUDj5jndKmqd3%2BrwDNotLiZAkfKG6YJNVRIg7ZGkw13pr0hNOXu7qbBFFc6n5QEa3wr56mvEZKiRKPmGrzi3eFJdT7g%2B4y9EAUa6PV9k8ZQVwtra8FBG2aGy9G41tmGqqawXFR2YHqP3xSErTH5i05S%2Fqdf%2F844Rdmy%2BVvHtIhmcvZ20iIjVasHSAR1FGGijL%2FVlFdqQTNkvCco49B0x5QhXCdXaY%2Bgj6qI3O2W8yqmrUO%2BQ%3D%3D--NaEAaiiIwara6Ke1--G4WSG39qhs5XE0%2FRLxowgA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.743878293.1753519376; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:42:56 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:42:56 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B6B6:363053:375647:4A4FC2:68849510
HTTP/2 200
date: Sat, 26 Jul 2025 08:42:57 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=274.150177,conversation_content-fragment;desc="conversation_content fragment";dur=657.927532,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=260.314272,nginx;desc="NGINX";dur=0.505799,glb;desc="GLB";dur=101.000776
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: B6B6:363053:375670:4A4FE8:68849510
[Xamarin.Android.Build.Tasks] simplify inputs to _CompileToDalvik by jonathanpeppers · Pull Request #2131 · dotnet/android · GitHub
jonathanpeppers
force-pushed
the
findcompiledjavafiles
branch
from
August 31, 2018 20:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] simplify inputs to _CompileToDalvik #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:findcompiledjavafiles
Sep 3, 2018
Merged
[Xamarin.Android.Build.Tasks] simplify inputs to _CompileToDalvik #2131
dellis1972
merged 1 commit into
dotnet:master
from
jonathanpeppers:findcompiledjavafiles
Sep 3, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look at the updated ones below |
Oops this is important: Fixing it... |
Recently I've been discovering more and more places where usage of `**\*.*` can hurt the performance of our build. In this case, the `_FindCompiledJavaFiles` target: <Target Name="_FindCompiledJavaFiles" DependsOnTargets="_CompileJava"> <CreateItem Include="$(IntermediateOutputPath)android\bin\classes\\**\*.class"> <Output TaskParameter="Include" ItemName="_CompiledJavaFiles" /> </CreateItem> </Target> This target is running even in builds with no changes, so we are *always* recursing directories and finding `*.class` files. But since we are using a `classes.zip` file now, we don't need to recurse and find the `*.class` files at all anymore! I was able to remove this target completely, and change `$(_CompileToDalvikInputs)` to use `$(IntermediateOutputPath)android\bin\classes.zip`. Less inputs also help build times, because MSBuild won't have to evaluate timestamps on all the `*.class` files. It can just look at the single `classes.zip` file. To see the difference, a build with no changes was taking: 46 ms _FindCompiledJavaFiles 1 calls 15 ms _CompileToDalvikWithDx 1 calls After these changes: 4 ms _CompileToDalvikWithDx 1 calls `_FindCompiledJavaFiles` is gone completely. I also made sure to include `_CompileJava` in `$(_CompileToDalvikDependsOnTargets)` in place of `_FindCompiledJavaFiles`.
b3fce8d
to
58e451b
Compare
After fixing the missing dependency for Updated logs here: FindCompiledJavaFiles.zip |
dellis1972
approved these changes
Sep 3, 2018
jonpryor
pushed a commit
that referenced
this pull request
Sep 5, 2018
) Recently I've been discovering more and more places where usage of `**\*.*` can hurt the performance of our build. In this case, the `_FindCompiledJavaFiles` target: <Target Name="_FindCompiledJavaFiles" DependsOnTargets="_CompileJava"> <CreateItem Include="$(IntermediateOutputPath)android\bin\classes\\**\*.class"> <Output TaskParameter="Include" ItemName="_CompiledJavaFiles" /> </CreateItem> </Target> This target is running even in builds with no changes, so we are *always* recursing directories and finding `*.class` files. But since we are using a `classes.zip` file now, we don't need to recurse and find the `*.class` files at all anymore! I was able to remove this target completely, and change `$(_CompileToDalvikInputs)` to use `$(IntermediateOutputPath)android\bin\classes.zip`. Less inputs also help build times, because MSBuild won't have to evaluate timestamps on all the `*.class` files. It can just look at the single `classes.zip` file. To see the difference, a build with no changes was taking: 46 ms _FindCompiledJavaFiles 1 calls 15 ms _CompileToDalvikWithDx 1 calls After these changes: 4 ms _CompileToDalvikWithDx 1 calls `_FindCompiledJavaFiles` is gone completely. I also made sure to include `_CompileJava` in `$(_CompileToDalvikDependsOnTargets)` in place of `_FindCompiledJavaFiles`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Recently I've been discovering more and more places where usage of
**\*.*
can hurt the performance of our build.In this case, the
_FindCompiledJavaFiles
target:This target is running even in builds with no changes, so we are
always recursing directories and finding
*.class
files.But since we are using a
classes.zip
file now, we don't need torecurse and find the
*.class
files at all anymore!I was able to remove this target completely, and change
$(_CompileToDalvikInputs)
to use$(IntermediateOutputPath)android\bin\classes.zip
. Less inputs alsohelp build times, because MSBuild won't have to evaluate timestamps on
all the
*.class
files. It can just look at the singleclasses.zip
file.
To see the difference, a build with no changes was taking:
After these changes:
_FindCompiledJavaFiles
is gone completely.I also made sure to include
_CompileJava
in$(_CompileToDalvikDependsOnTargets)
in place of_FindCompiledJavaFiles
.