CARVIEW |
Select Language
HTTP/2 301
date: Sat, 26 Jul 2025 08:41:54 GMT
content-length: 0
location: https://github.com/dotnet/android/pull/2130
server-timing: nginx;desc="NGINX";dur=1.176401,glb;desc="GLB";dur=101.065492
x-voltron-version: a2eb102
vary: Accept-Encoding, Accept, X-Requested-With
server: github.com
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
set-cookie: _gh_sess=Iq0skkLMqlRuq0zGqIlv18Fy1odY7Q8bvRNAVU2V1PmcjuZxJBbqITeTbeGKLk9rEw2RrvWfE3rS195C0cv2fddmro1mPDA6Sf3kBA4CVmf89O53EuqKoYbAFiGfGvCuXQY%2BOXuPG5u4GdTkavyCzL6uu4JT9VBRWcQLi2w2a2IJdLr7MiWybUYcIQIklH2TjBLhknhD9W2tZgbx%2FiNp7K57rxk0opzTeMlqeZvo8uM1joZBFWKfn%2BKmjVr9WCQGikh9GHxhG0LEa%2FqV6GsrHg%3D%3D--AVpEPDzz61hpwyuc--vaZVemcn9AVnnXM%2FhTY6pw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2059516238.1753519313; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:53 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 08:41:53 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DCD4:1AEE08:3740CB:4A32FE:688494D1
HTTP/2 200
date: Sat, 26 Jul 2025 08:41:54 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=380.038019,conversation_content-fragment;desc="conversation_content fragment";dur=500.945357,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=321.524733,nginx;desc="NGINX";dur=1.040664,glb;desc="GLB";dur=101.424776
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
x-github-request-id: DCD4:1AEE08:3740EB:4A332A:688494D1
[Xamarin.Android.Build.Tasks] precompile SetVsMonoAndroidRegistryKey by jonathanpeppers · Pull Request #2130 · dotnet/android · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 555
[Xamarin.Android.Build.Tasks] precompile SetVsMonoAndroidRegistryKey #2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:setvsmonoandroidregistrykey
Sep 5, 2018
Merged
[Xamarin.Android.Build.Tasks] precompile SetVsMonoAndroidRegistryKey #2130
jonpryor
merged 1 commit into
dotnet:master
from
jonathanpeppers:setvsmonoandroidregistrykey
Sep 5, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `Xamarin.Android.Sdk.props` we have some inline C# code for a MSBuild task named `SetVsMonoAndroidRegistryKey`. Which is understandable, since the code needed is so simple. But thinking about it, MSBuild has to *compile* this code to run it. Which seems inherently slower than if we compiled the code during our build. Currently its entire parent target, `RedirectMonoAndroidSdkPaths`, takes: 157 ms RedirectMonoAndroidSdkPaths 1 calls I moved this task inside `Xamarin.Android.Build.Tasks.dll`, and we appear to get some improvements "for free": 76 ms RedirectMonoAndroidSdkPaths 1 calls I looked at some past logs, and there are some times where the `RedirectMonoAndroidSdkPaths` target was taking over 200ms. I suspect MSBuild might also have some caching functionality for inlined C# code. There might be a cached assembly somewhere? Not sure. What makes this a better fix is that this target runs for all builds--even builds with no changes. General changes: - The `<UsingTask />` doesn't need a condition, since it will be lazily evaluated anyways. - Used string interpolation where it looked nicer. - Used `LogDebugMessage` and improved the log message.
Logs for this: RedirectMonoAndroidSdkPaths.zip |
I think the build failure is unrelated, this target doesn't run at all on Mac?
The error is:
|
jonpryor
pushed a commit
that referenced
this pull request
Sep 5, 2018
…2130) In `Xamarin.Android.Sdk.props` we have some inline C# code for a MSBuild task named `SetVsMonoAndroidRegistryKey`. Which is understandable, since the code needed is so simple. But thinking about it, MSBuild has to *compile* this code to run it. Which seems inherently slower than if we compiled the code during our build. Currently its entire parent target, `RedirectMonoAndroidSdkPaths`, takes: 157 ms RedirectMonoAndroidSdkPaths 1 calls I moved this task inside `Xamarin.Android.Build.Tasks.dll`, and we appear to get some improvements "for free": 76 ms RedirectMonoAndroidSdkPaths 1 calls I looked at some past logs, and there are some times where the `RedirectMonoAndroidSdkPaths` target was taking over 200ms. I suspect MSBuild might also have some caching functionality for inlined C# code. There might be a cached assembly somewhere? Not sure. What makes this a better fix is that this target runs for all builds--even builds with no changes. General changes: - The `<UsingTask/>` doesn't need a condition, since it will be lazily evaluated anyways. - Used string interpolation where it looked nicer. - Used `LogDebugMessage()` and improved the log message.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
In
Xamarin.Android.Sdk.props
we have some inline C# code for aMSBuild task named
SetVsMonoAndroidRegistryKey
. Which isunderstandable, since the code needed is so simple. But thinking about
it, MSBuild has to compile this code to run it. Which seems
inherently slower than if we compiled the code during our build.
Currently its entire parent target,
RedirectMonoAndroidSdkPaths
,takes:
I moved this task inside
Xamarin.Android.Build.Tasks.dll
, and weappear to get some improvements "for free":
I looked at some past logs, and there are some times where the
RedirectMonoAndroidSdkPaths
target was taking over 200ms. I suspectMSBuild might also have some caching functionality for inlined C#
code. There might be a cached assembly somewhere? Not sure.
What makes this a better fix is that this target runs for all
builds--even builds with no changes.
General changes:
<UsingTask />
doesn't need a condition, since it will belazily evaluated anyways.
LogDebugMessage
and improved the log message.