| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 03:08:56 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=339.294212,conversation_content-fragment;desc="conversation_content fragment";dur=1414.027178,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=378.799066,nginx;desc="NGINX";dur=1.503372,glb;desc="GLB";dur=138.324478
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=IKOjCDYdAPKlUJNScTs%2FwZlESs0R7txZnsUnyHRgBbl1m9xkESFuahBUq%2FvuxDRKpGbDFsZlPEXsVL54KWJtCmSZsIELZnskxEwV%2BhPa44dLbe73ln6hOvCInUaykiz0ZM01SJwlq6Wgymb1Iq%2FAeosJUELgkxew6Gndo0cBfLZoC89z0UjIEOL1uCahteR4a8clRktBfG69%2BPtH%2BDQNDq907dt4iwLOVVweAmlzyyM%2Fz3fM93JIXg20%2BVeJjdCAf8g%2Fy5szeqPNTFqsRQGMSg%3D%3D--3qLBnVtWKfHM0apg--727wqWe0ciPLKsXkBS1EtQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1649881569.1760152135; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:08:55 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:08:55 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: CADC:19F5EE:2412BA:350053:68E9CA47
Added PHPDoc for cmd_starts_with() method by PARTHVATALIYA · Pull Request #6034 · wp-cli/wp-cli · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1k
Added PHPDoc for cmd_starts_with() method #6034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe we have a ton of missing docblocks in a lot of other places—would you like to help improve them more holistically? :) |
|
Thank you for pointing that out! I'd be happy to help improve the docblocks more holistically. Let me know if there's a specific area you'd like me to focus on. 😊 |
|
Pretty much everything in the |
|
Actually, many methods are missing docblocks, and I’m not entirely sure about the purpose of each method. How can I write a proper docblock for the methods in the PHP folder without fully understanding the functionality of each one? |
mrsdizzie
requested changes
Jan 24, 2025
|
Fair enough :) let‘s start with this one then |
mrsdizzie
requested changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't meant to be so Nitpicky on a small PR but this is a particular case where cmd / command happens to refer to the WP-CLI binary, while in most other contexts it actually refers to a specific wp cli command (user, core, db, etc...) so it is better to clarify (even in the next function below "command" starts to refer to specific wp-cli commands again
mrsdizzie
approved these changes
Feb 4, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fix: #6033
Add PHPDoc for
cmd_starts_with()method inRunnerclass to improve code readability, align with WordPress coding standards, and help developers understand the purpose and behaviour of the function.