| CARVIEW |
Select Language
HTTP/2 200
date: Thu, 09 Oct 2025 03:58:34 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=498.430875,conversation_content-fragment;desc="conversation_content fragment";dur=1274.818192,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=397.582726,nginx;desc="NGINX";dur=1.021256,glb;desc="GLB";dur=138.065347
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=da4aRyent5nm9QN1pbwHpX7j08KBWqlZnXqXPZeEpFAT25cm%2F4F2yI3AyrtOObqA9IaQOe3HB3eAuC6EcpOxt6jQ1X%2BHDSZLt8U8NYyJCUjJRJVkc5LbGk6Fw0fELkwomADBgbrcB0hu%2Fr3RJBytxqISb1XEZm2Q%2FwRAhE%2FnHeEFi3L8eCzuot9QujcY8dFc6qfmJ%2BSZyrHdP%2FfLOgImQM0Ed7RSnuhc0hKZwUulm9hVpBvZDI7rcMK%2FQ1HMAcgfC%2BQS1CLLTiyRzw8sDbjJtQ%3D%3D--%2FdCsQL8z%2Fj%2B5ymTA--0hCmoId58RyNxDz2mp8zZw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.577360303.1759982312; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 03:58:32 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Fri, 09 Oct 2026 03:58:32 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8460:264CB4:2D943F:403817:68E732E8
Address warnings with filenames ending in fullstop on Windows by BrianHenryIE · Pull Request #5951 · wp-cli/wp-cli · GitHub
swissspidy
changed the title
Fix "Warning: copy(-.): Failed to open stream: Permission denied" on Windows where FileCache used filename ending in
Address warnings with filenames ending in fullstop on Windows
May 23, 2024
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1k
Address warnings with filenames ending in fullstop on Windows #5951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swissspidy
merged 12 commits into
wp-cli:main
from
BrianHenryIE:add/filecache-import-tests
May 23, 2024
Merged
Address warnings with filenames ending in fullstop on Windows #5951
swissspidy
merged 12 commits into
wp-cli:main
from
BrianHenryIE:add/filecache-import-tests
May 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the failing unit tests are addressed by #5950 |
swissspidy
reviewed
May 23, 2024
swissspidy
reviewed
May 23, 2024
swissspidy
reviewed
May 23, 2024
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
…wp-cli into add/filecache-import-tests
|
Hmm... the PHPUnit methods are static methods but the documentation's examples do use the instance
|
swissspidy
approved these changes
May 23, 2024
swissspidy
changed the title
.
lipemat
added a commit
to lipemat/wp-cli-bundle
that referenced
this pull request
Jun 6, 2024
The sister pull request was merged which resolved the issue. wp-cli/wp-cli#5951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
@lipemat opened PR #5947 to address an issue with filenames of premium plugins.
The failure was occurring with:
Tests with those values passed on MacOS, but Microsoft's documentation says:
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions
The primary fix for this is to
rtrim()the.duringFileCache::validate_key(): c38a371, confirmed working: #5947 (comment)Before realising the root issue, I had added a fix for the error message, 32ba58d, to begin, I needed to add a test for the happy path: 6f0b0e9, and I also added some comments and typehints I needed to debug.