You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@danielbachhuber What's the reasoning behind creating a separate repository for this? This will add a whole heap of extra effort (package setup, release process, test setup & CI/CD, etc...). For these few files, why not just stick with adding it to the package that is the "framework" package? Did you see a specific use case for using this outside of WP-CLI?
@schlessera So we can start using the classes right away, instead of waiting for the framework to be tagged, dealing with back compat, etc.
I usually deal with this by pulling in the main branch of the framework where needed, that's why they all come with a branch alias. During the release process, this is all corrected with stable tagged versions again.
Our automation should solve this, no?
Every package not only adds extra maintenance overhead and slows down CI/CD, but also introduces a new "API" in the form of an officially accessible package that has its own versioning/dependency tree hassles.
Moreover, I'd like to add that we cannot add a new package every time the framework would require an update that needs to immediately be accessible to a command repository.
I usually deal with this by pulling in the main branch of the framework where needed, that's why they all come with a branch alias. During the release process, this is all corrected with stable tagged versions again.
@schlessera Ok, can you own setting this up? It sounds more complicated than what I proposed, but I don't have a strong opinion about this.
@danielbachhuber I set this up. It's not complicated at all, as all packages are already configured, it just means bumping the minimum framework version in the corresponding packages to a not-yet-released version (which then automatically pulls in dev-main). I added some further explanation here: wp-cli/entity-command#442 (comment)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5864
See #5837
Let's have this live in its own repository