| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 03:13:29 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=396.150207,conversation_content-fragment;desc="conversation_content fragment";dur=1084.07294,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=359.069735,nginx;desc="NGINX";dur=0.913207,glb;desc="GLB";dur=137.734145
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=Srbs49iCR74UDBvXMSMEVKuWJutHYM%2FtNtKUwUh99lBlxXqlXPPepzYZfGpJlyVmr%2F3DJvJmIGIQmDKiY5dFJ7gkVuDhFQjxSHbBK2uVgKZEzj0W3JLIIirz0FmX%2FzsB0jaU%2BxUxbLFLUJwvvNboNc9%2F8VYZ06RGJUBEAhsMI2GarFG5hGnHbF%2FqJPCVJSRZ%2FCZZPfnynZ1NmPp3oHVYtQVf98tjgDEjQ34dmwR8zR3%2B6Dz3OFdY%2FswZ6iIOO33mrGRX0k1TqtyDPURrlbPmaw%3D%3D--6uqExBwJhykHiThN--akkvkMQ5nU1XyCL73pps1Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1746824953.1760152408; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:13:28 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:13:28 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DF16:364294:24B8EB:35D1A7:68E9CB58
Add missing required arguments when using `--prompt` by 2ndkauboy · Pull Request #5865 · wp-cli/wp-cli · GitHub
Add missing required arguments when using
Add missing required arguments when using
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
4 times, most recently
from
November 10, 2023 12:14
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
November 10, 2023 13:06
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
November 10, 2023 13:33
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
November 10, 2023 13:35
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1k
Add missing required arguments when using --prompt
#5865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swissspidy
merged 1 commit into
wp-cli:main
from
2ndkauboy:fix/5768-prompt-missing-required-parameters
Nov 10, 2023
Merged
Add missing required arguments when using --prompt
#5865
swissspidy
merged 1 commit into
wp-cli:main
from
2ndkauboy:fix/5768-prompt-missing-required-parameters
Nov 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
4 times, most recently
from
7d10ddc to
5645c05
Compare
swissspidy
reviewed
Nov 10, 2023
php/WP_CLI/Dispatcher/Subcommand.php
Outdated
| 'wp %s %s', | ||
| $cmd, | ||
| ltrim( Utils\assoc_args_to_str( $actual_args ), ' ' ) | ||
| ltrim( implode( ' ', [ Utils\args_to_str( $args ), Utils\assoc_args_to_str( $actual_args ) ] ), ' ' ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| ltrim( implode( ' ', [ Utils\args_to_str( $args ), Utils\assoc_args_to_str( $actual_args ) ] ), ' ' ) | |
| ltrim( implode( '', [ Utils\args_to_str( $args ), Utils\assoc_args_to_str( $actual_args ) ] ), ' ' ) |
This might fix the double space issue. assoc_args_to_str() will have a leading space, so no need to add another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came up with a solution - forgot to push it before lunch 🙈 - I hope this works now and passes all the tests.
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
5645c05 to
c42c372
Compare
|
@2ndkauboy Looks like it needs a PHPCS fix |
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
c42c372 to
b1f71e0
Compare
|
@danielbachhuber you are right. It's fixed now. |
When using the `--prompt` argument on a command, the executed command gets logged, showing the command and arguments the prompt had collected. This logged command, however, lacks all required `$args` and only lists the `$assoc_args` (that are not empty). This patch will add the required arguments as well.
2ndkauboy
force-pushed
the
fix/5768-prompt-missing-required-parameters
branch
from
b1f71e0 to
438cdbc
Compare
swissspidy
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
When using the
--promptargument on a command, the executed command gets logged, showing the command and arguments the prompt had collected.This logged command, however, lacks all required
$argsand only lists the$assoc_args(that are not empty).This patch will add the required arguments as well.
Fixes #5768
Related: #5859