Merge pull request #188 from wp-cli/fix/unit-tests

swissspidy · web-flow · commit 3370dd88ddf9 · 2024-05-22T07:26:05.000+02:00
diff --git a/.gitignore b/.gitignore
@@ -9,3 +9,5 @@ composer.lock
 phpunit.xml
 phpcs.xml
 .phpcs.xml
+.phpunit.cache
+.phpunit.result.cache
diff --git a/phpcs.xml.dist b/phpcs.xml.dist
@@ -18,7 +18,7 @@
 	<exclude-pattern>*/src/WP_CLI/JsonManipulator\.php$</exclude-pattern>
 	<exclude-pattern>*/src/WP_CLI/Package/Compat/Min_Composer_1_10/NullIOMethodsTrait\.php$</exclude-pattern>
 	<exclude-pattern>*/src/WP_CLI/Package/Compat/Min_Composer_2_3/NullIOMethodsTrait\.php$</exclude-pattern>
-	<exclude-pattern>*/tests/test-json-manipulator\.php$</exclude-pattern>
+	<exclude-pattern>*/tests/JsonManipulatorTest\.php$</exclude-pattern>
 
 	<!-- Show progress. -->
 	<arg value="p"/>
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,11 +1,20 @@
-<phpunit
-	bootstrap="vendor/autoload.php"
-	colors="true"
-	>
-	<testsuites>
-		<testsuite>
-			<directory prefix="spec-" suffix=".php">tests/</directory>
-			<directory prefix="test-" suffix=".php">tests/</directory>
-		</testsuite>
-	</testsuites>
+<phpunit xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance"
+		 xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
+		 bootstrap="vendor/autoload.php"
+		 backupGlobals="false"
+		 beStrictAboutCoversAnnotation="true"
+		 beStrictAboutOutputDuringTests="true"
+		 beStrictAboutTestsThatDoNotTestAnything="true"
+		 beStrictAboutTodoAnnotatedTests="true"
+		 colors="true"
+		 verbose="true">
+	<testsuite name="wp-cli/package-command tests">
+		<directory suffix="Test.php">tests</directory>
+	</testsuite>
+
+	<filter>
+		<whitelist processUncoveredFilesFromWhitelist="true">
+			<directory suffix=".php">src</directory>
+		</whitelist>
+	</filter>
 </phpunit>
diff --git a/tests/ComposerJsonTest.php b/tests/ComposerJsonTest.php
@@ -28,10 +28,10 @@ public function set_up() {
 		WP_CLI::set_logger( $this->logger );
 
 		// Enable exit exception.
+
 		$class_wp_cli_capture_exit = new \ReflectionProperty( 'WP_CLI', 'capture_exit' );
 		$class_wp_cli_capture_exit->setAccessible( true );
-		$this->prev_capture_exit = $class_wp_cli_capture_exit->getValue();
-		$class_wp_cli_capture_exit->setValue( true );
+		$class_wp_cli_capture_exit->setValue( null, true );
 
 		$this->temp_dir = Utils\get_temp_dir() . uniqid( 'wp-cli-test-package-composer-json-', true ) . '/';
 		mkdir( $this->temp_dir );
@@ -44,7 +44,7 @@ public function tear_down() {
 		// Restore exit exception.
 		$class_wp_cli_capture_exit = new \ReflectionProperty( 'WP_CLI', 'capture_exit' );
 		$class_wp_cli_capture_exit->setAccessible( true );
-		$class_wp_cli_capture_exit->setValue( $this->prev_capture_exit );
+		$class_wp_cli_capture_exit->setValue( null, $this->prev_capture_exit );
 
 		rmdir( $this->temp_dir );
 
diff --git a/tests/JsonManipulatorTest.php b/tests/JsonManipulatorTest.php
@@ -26,7 +26,7 @@ public function testAddLink($json, $type, $package, $constraint, $expected)
         $this->assertEquals($expected, $manipulator->getContents());
     }
 
-    public function linkProvider()
+    public static function linkProvider()
     {
         return array(
             array(
@@ -1297,7 +1297,7 @@ public function testAddLinkAndSortPackages($json, $type, $package, $constraint,
         $this->assertEquals($expected, $manipulator->getContents());
     }
 
-    public function providerAddLinkAndSortPackages()
+    public static function providerAddLinkAndSortPackages()
     {
         return array(
             array(
@@ -1380,7 +1380,7 @@ public function testRemoveSubNode($json, $name, $expected, $expectedContent = nu
         }
     }
 
-    public function removeSubNodeProvider()
+    public static function removeSubNodeProvider()
     {
         return array(
             'works on simple ones first' => array(
@@ -2374,7 +2374,7 @@ public function testAddLinkCaseInsensitive($json, $type, $package, $constraint,
         $this->assertEquals($expected, $manipulator->getContents());
     }
 
-    public function providerAddLinkCaseInsensitive()
+    public static function providerAddLinkCaseInsensitive()
     {
         return array(
             array(
@@ -2441,7 +2441,7 @@ public function testAddSubNodeCase($json, $mainNode, $name, $caseInsensitive, $e
 		$this->assertSame($expected, $manipulator->getContents());
     }
 
-    public function providerAddSubNodeCase()
+    public static function providerAddSubNodeCase()
     {
         return array(
             array(
@@ -2504,7 +2504,7 @@ public function testRemoveSubNodeCaseInsensitive($json, $mainNode, $name, $expec
         }
     }
 
-    public function providerRemoveSubNodeCaseInsensitive()
+    public static function providerRemoveSubNodeCaseInsensitive()
     {
         return array(
             array(

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function testAddLink($json, $type, $package, $constraint, $expected)`
`26`	`26`	`$this->assertEquals($expected, $manipulator->getContents());`
`27`	`27`	`}`
`28`	`28`
`29`		`- public function linkProvider()`
	`29`	`+ public static function linkProvider()`
`30`	`30`	`{`
`31`	`31`	`return array(`
`32`	`32`	`array(`
`@@ -1297,7 +1297,7 @@ public function testAddLinkAndSortPackages($json, $type, $package, $constraint,`
`1297`	`1297`	`$this->assertEquals($expected, $manipulator->getContents());`
`1298`	`1298`	`}`
`1299`	`1299`
`1300`		`- public function providerAddLinkAndSortPackages()`
	`1300`	`+ public static function providerAddLinkAndSortPackages()`
`1301`	`1301`	`{`
`1302`	`1302`	`return array(`
`1303`	`1303`	`array(`
`@@ -1380,7 +1380,7 @@ public function testRemoveSubNode($json, $name, $expected, $expectedContent = nu`
`1380`	`1380`	`}`
`1381`	`1381`	`}`
`1382`	`1382`
`1383`		`- public function removeSubNodeProvider()`
	`1383`	`+ public static function removeSubNodeProvider()`
`1384`	`1384`	`{`
`1385`	`1385`	`return array(`
`1386`	`1386`	`'works on simple ones first' => array(`
`@@ -2374,7 +2374,7 @@ public function testAddLinkCaseInsensitive($json, $type, $package, $constraint,`
`2374`	`2374`	`$this->assertEquals($expected, $manipulator->getContents());`
`2375`	`2375`	`}`
`2376`	`2376`
`2377`		`- public function providerAddLinkCaseInsensitive()`
	`2377`	`+ public static function providerAddLinkCaseInsensitive()`
`2378`	`2378`	`{`
`2379`	`2379`	`return array(`
`2380`	`2380`	`array(`
`@@ -2441,7 +2441,7 @@ public function testAddSubNodeCase($json, $mainNode, $name, $caseInsensitive, $e`
`2441`	`2441`	`$this->assertSame($expected, $manipulator->getContents());`
`2442`	`2442`	`}`
`2443`	`2443`
`2444`		`- public function providerAddSubNodeCase()`
	`2444`	`+ public static function providerAddSubNodeCase()`
`2445`	`2445`	`{`
`2446`	`2446`	`return array(`
`2447`	`2447`	`array(`
`@@ -2504,7 +2504,7 @@ public function testRemoveSubNodeCaseInsensitive($json, $mainNode, $name, $expec`
`2504`	`2504`	`}`
`2505`	`2505`	`}`
`2506`	`2506`
`2507`		`- public function providerRemoveSubNodeCaseInsensitive()`
	`2507`	`+ public static function providerRemoveSubNodeCaseInsensitive()`
`2508`	`2508`	`{`
`2509`	`2509`	`return array(`
`2510`	`2510`	`array(`