Merge pull request #139 from ernilambar/138-plugin-language

swissspidy · web-flow · commit 5bd30672fd54 · 2024-02-19T10:02:02.000+01:00
diff --git a/features/language-plugin.feature b/features/language-plugin.feature
@@ -157,7 +157,7 @@ Feature: Manage translation files for a WordPress install
     When I try `wp language plugin install hello-dolly en_GB de_DE invalid_lang`
     Then STDERR should be:
       """
-      Warning: Language 'invalid_lang' not available.
+      Warning: Language 'invalid_lang' for 'hello-dolly' not available.
       """
     And STDOUT should contain:
       """
diff --git a/features/language-theme.feature b/features/language-theme.feature
@@ -142,7 +142,7 @@ Feature: Manage translation files for a WordPress install
     When I try `wp language theme install twentyten invalid_lang`
     Then STDERR should be:
       """
-      Warning: Language 'invalid_lang' not available.
+      Warning: Language 'invalid_lang' for 'twentyten' not available.
       """
     And STDOUT should be:
       """
diff --git a/src/WP_CLI/CommandWithTranslation.php b/src/WP_CLI/CommandWithTranslation.php
@@ -216,7 +216,7 @@ protected function download_language_pack( $download, $slug = null ) {
 		}
 
 		if ( ! $translation_to_load ) {
-			return new \WP_Error( 'not_found', "Language '{$download}' not available." );
+			return new \WP_Error( 'not_found', $slug ? "Language '{$download}' for '{$slug}' not available." : "Language '{$download}' not available." );
 		}
 		$translation = (object) $translation;
 
@@ -235,7 +235,7 @@ protected function download_language_pack( $download, $slug = null ) {
 		}
 
 		if ( ! $result ) {
-			return new \WP_Error( 'not_installed', "Could not install language '{$download}'." );
+			return new \WP_Error( 'not_installed', $slug ? "Could not install language '{$download}' for '{$slug}'." : "Could not install language '{$download}'." );
 		}
 
 		return $translation->language;

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ protected function download_language_pack( $download, $slug = null ) {`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`if ( ! $translation_to_load ) {`
`219`		`- return new \WP_Error( 'not_found', "Language '{$download}' not available." );`
	`219`	`+ return new \WP_Error( 'not_found', $slug ? "Language '{$download}' for '{$slug}' not available." : "Language '{$download}' not available." );`
`220`	`220`	`}`
`221`	`221`	`$translation = (object) $translation;`
`222`	`222`
`@@ -235,7 +235,7 @@ protected function download_language_pack( $download, $slug = null ) {`
`235`	`235`	`}`
`236`	`236`
`237`	`237`	`if ( ! $result ) {`
`238`		`- return new \WP_Error( 'not_installed', "Could not install language '{$download}'." );`
	`238`	`+ return new \WP_Error( 'not_installed', $slug ? "Could not install language '{$download}' for '{$slug}'." : "Could not install language '{$download}'." );`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`return $translation->language;`