You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wordpress.pot: this looks like the strings for the front-end? No strings coming from theme.json need to be displayed in the front-end.
hello-dolly.pot: no strings coming from theme.json are related to the hello-dolly plugin.
wordpress-admin.pot: strings to load on the admin. The strings coming from theme.json need to be available in all block editors. If this is the file we load for that, they need to be loaded here.
wordpress-admin-network.pot : this sounds like the admin network screen. No strings coming from theme.json here.
I suppose we should exclude wp-content from all those contexts, apart for some minor tweaks (include dolly, etc.). This would suffice to prevent theme-defined strings (be in PHP like patterns or functions.php, or any of the theme.json (main or style variations) from being picked for the core pot.
With the limited context I have about how the extraction works, I believe the i18n-command should never skip a path. It's the consumer responsibility to configure the command properly and they can already --exclude-* paths and --skip-* types of files (PHP, JSON, etc.).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
theme.json
file in any level, for any type of project/styles
folder if it is a theme (this restriction is new)Fixes #423