CARVIEW |
Select Language
HTTP/2 200
date: Sat, 11 Oct 2025 03:10:51 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=305.58105,conversation_content-fragment;desc="conversation_content fragment";dur=627.65836,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=295.726931,nginx;desc="NGINX";dur=0.709604,glb;desc="GLB";dur=138.943657
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=JdjyhBZ0gy1K%2BIQyJd%2ByjgM4wC1jzZMqvlGqjbT3o0OD%2Byxxx9DMzeRoP9x9F2LyXiPKsEURDHjGH0OX3P3BJ174E%2FeYlLYduAYxYBrOkNJsNUO0XD4Kgn%2BgIcpPt6oTQAHB4tMF1v3wbPNk%2FaUTzyXNiKdGDvUVbG0gRrc3oehG5iVaGH6bROc%2FAgHW69EiZDRBAR68Fui2CwliDHgqFCHma7LlJ4ke6XjhtHkVaifk2eQ0jIjnGKhJuSHLjJUiiReb1AHHdnol9m9%2FyufoiA%3D%3D--77KLF%2FjXTgmIHZWa--pHff4gNcpGC38emYY%2FEIVQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.405693476.1760152250; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:10:50 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 11 Oct 2026 03:10:50 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D9D6:9DC1D:23C5B7:34C341:68E9CABA
Translate "description" field from theme.json by ramonjd Β· Pull Request #408 Β· wp-cli/i18n-command Β· GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 60
Translate "description" field from theme.json #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
swissspidy
merged 1 commit into
wp-cli:main
from
ramonjd:add/description-field-to-theme-json
Jul 3, 2024
Merged
Translate "description" field from theme.json #408
swissspidy
merged 1 commit into
wp-cli:main
from
ramonjd:add/description-field-to-theme-json
Jul 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add expectation to existing behat tests
I approved the core PR and this PR is also working well for me. I'll leave @swissspidy comment on this, but my understanding is that we should merge the core PR and right after merge this one. |
Correct. Otherwise tests are failing, as you can see now :-) |
The core PR has been merged as of WordPress/wordpress-develop@2930212 |
swissspidy
approved these changes
Jul 3, 2024
Thanks for the help, folks ππ» |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
This PR:
Important
A WordPress Core PR exists to add the "description" key to
src/wp-includes/theme-i18n.json
. This has not yet been committed.TODO
Context
A "description" key was added to theme.json in WordPress/gutenberg#45242
The Gutenberg PR was synced to Core in WordPress/wordpress-develop#4687
Unfortunately, a corresponding entry to the theme.json i18n schema was not part of the change.
Core trac ticket: https://core.trac.wordpress.org/ticket/61543
Testing
Set up
Before running any of the test (manual or automatic), make sure to set the
THEME_JSON_SOURCE
to '' (empty string) so theThemeJsonExtractor
picks the the local backup file with the changes atassets/theme-i18n.json
.Automated tests:
Manual tests:
Create a new directory called
foo-theme
that contains a theme.json file with the following contents:Run
vendor/bin/wp i18n make-pot foo-theme
Verify that there's a
foo-theme/foo-theme.pot
file and that the "My style variation description" string is present as well as its context "Style variation description".You should see something like: