Merge pull request #399 from meszarosrob/fix/398-pot-license-for-themes

ernilambar · web-flow · commit aa8338b1a4e2 · 2024-04-26T17:19:29.000+05:45
Ensure that the POT file use the same license as the theme
diff --git a/features/makepot.feature b/features/makepot.feature
@@ -3820,6 +3820,37 @@ Feature: Generate a POT file of a WordPress project
       msgid "Other pattern description."
       """
 
+  Scenario: Use the license from the theme header
+    Given an empty foo-theme directory
+    And a foo-theme/style.css file:
+      """
+      /*
+      Theme Name: Foo Theme
+      License: GNU General Public License v2 or later
+      */
+      """
+
+    When I run `wp i18n make-pot foo-theme foo-theme.pot`
+    Then the foo-theme.pot file should contain:
+      """
+      # This file is distributed under the GNU General Public License v2 or later.
+      """
+
+  Scenario: Use the same license as the theme
+    Given an empty foo-theme directory
+    And a foo-theme/style.css file:
+      """
+      /*
+      Theme Name: Foo Theme
+      */
+      """
+
+    When I run `wp i18n make-pot foo-theme foo-theme.pot`
+    Then the foo-theme.pot file should contain:
+      """
+      # This file is distributed under the same license as the Foo Theme theme.
+      """
+
   Scenario: Ignores a standard set of directories as expected
     Given an empty foo-plugin directory
     And a foo-plugin/foo-plugin.php file:
diff --git a/src/MakePotCommand.php b/src/MakePotCommand.php
@@ -902,7 +902,7 @@ protected function get_file_comment() {
 		}
 
 		if ( isset( $this->main_file_data['Theme Name'] ) ) {
-			if ( isset( $this->main_file_data['License'] ) ) {
+			if ( ! empty( $this->main_file_data['License'] ) ) {
 				return sprintf(
 					"Copyright (C) %1\$s %2\$s\nThis file is distributed under the %3\$s.",
 					date( 'Y' ), // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
@@ -920,7 +920,7 @@ protected function get_file_comment() {
 		}
 
 		if ( isset( $this->main_file_data['Plugin Name'] ) ) {
-			if ( isset( $this->main_file_data['License'] ) && ! empty( $this->main_file_data['License'] ) ) {
+			if ( ! empty( $this->main_file_data['License'] ) ) {
 				return sprintf(
 					"Copyright (C) %1\$s %2\$s\nThis file is distributed under the %3\$s.",
 					date( 'Y' ), // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date
