You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried using the --force flag, but it seems like it's going to require more updates to the initial feature spec than the necessary. Here's an example where it didn't work as expected. Since the twentytwenty theme is already installed, if I use --force, I'll have to change the output message from "Theme installed successfully." to "Theme updated successfully."
@ernilambar@swissspidy Thought on this. Do you think this is the preferable approach?
Ideally I'd prefer to keep the updates to a minimum.
I think you added --force to the command in When. We should not be updating those arguments. You can add And I run wp theme delete --all --force in Given (after line 4) in theme-install.feature. (Apologies. I think I didn't make that clear in earlier comment)
@ernilambar this error is a bit weird to me. Somehow it does not happen when I run this test in local. What do you think I did wrong here? It seems there are slight differences between the environment that missed in my local.
009 Scenario: Parent theme is active when its child is active # features/theme.feature:577
And I run `wp theme delete twentytwelve --force` # features/theme.feature:579
$ wp theme delete twentytwelve --force
Success: Theme already deleted.
If I did not run wp theme delete twentytwelve --force, it would throw:
001 Scenario: Parent theme is active when its child is active # features/theme.feature:577
And I run `wp theme install twentytwelve` # features/theme.feature:580
$ wp theme install twentytwelve
Success: Theme already installed.
Warning: twentytwelve: Theme already installed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request updates the theme to install in the feature tests from
p2
totwentytwelve
since thep2
has been removed from WP.org repository.Reference
P2
theme has been retiredย wp-cli-tests#200