You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm adding the field update_version as a default field for plugin and theme commands. If no update_version is available we return an empty string following the same pattern as version itself.
Now wp plugin list and wp theme list display a table similar to:
+------------+----------+--------+---------+----------------+-------------+
| name | status | update | version | update_version | auto_update |
+------------+----------+--------+---------+----------------+-------------+
| akismet | inactive | none | 5.3 | | off |
| hello | inactive | none | 1.7.2 | | off |
| Zombieland | inactive | none | 0.1.0 | | off |
| no-mail | must-use | none | | | off |
| polyfills | must-use | none | | | off |
+------------+----------+--------+---------+----------------+-------------+
+-------------------+----------+--------+---------+----------------+-------------+
| name | status | update | version | update_version | auto_update |
+-------------------+----------+--------+---------+----------------+-------------+
| twentytwentyfour | active | none | 1.0 | | off |
| twentytwentythree | inactive | none | 1.3 | | off |
| twentytwentytwo | inactive | none | 1.6 | | off |
+-------------------+----------+--------+---------+----------------+-------------+
Testing instructions
Run composer behat -- features/plugin-update.feature
Run composer behat -- features/plugin.feature
Run composer behat -- features/upgradables.feature
Thanks for the quick review! I fixed the alignment issues (1335956). I also updated some comments on the functions. (7fb9b9b)
And I realized that the json format is returning null instead of an empty string. Is that something I need to change?
I would appreciate where that part of the code lives.
And I realized that the json format is returning null instead of an empty string. Is that something I need to change?
I would appreciate where that part of the code lives.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_version
in default plugin list and theme list fields #198Description
I'm adding the field
update_version
as a default field forplugin
andtheme
commands. If noupdate_version
is available we return an empty string following the same pattern asversion
itself.Now
wp plugin list
andwp theme list
display a table similar to:Testing instructions
composer behat -- features/plugin-update.feature
composer behat -- features/plugin.feature
composer behat -- features/upgradables.feature
composer behat -- features/theme.feature