Merge pull request #445 from itsmekopila/fix/429

swissspidy · web-flow · commit d21a2f504ac4 · 2025-05-06T21:17:53.000+02:00
diff --git a/features/plugin-auto-updates-status.feature b/features/plugin-auto-updates-status.feature
@@ -114,3 +114,10 @@ Feature: Show the status of auto-updates for WordPress plugins
       hello,disabled
       duplicate-post,disabled
       """
+
+  @require-wp-5.5
+  Scenario: Handle malformed option value
+    When I run `wp option update auto_update_plugins ""`
+    And I try `wp plugin auto-updates status hello`
+    Then the return code should be 0
+    And STDERR should be empty
diff --git a/src/Plugin_AutoUpdates_Command.php b/src/Plugin_AutoUpdates_Command.php
@@ -85,7 +85,7 @@ public function enable( $args, $assoc_args ) {
 		$plugins      = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
@@ -162,7 +162,7 @@ public function disable( $args, $assoc_args ) {
 		$plugins      = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
@@ -278,7 +278,7 @@ public function status( $args, $assoc_args ) {
 		$plugins      = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
diff --git a/src/Plugin_Command.php b/src/Plugin_Command.php
@@ -751,7 +751,7 @@ protected function get_item_list() {
 
 		$auto_updates = get_site_option( Plugin_AutoUpdates_Command::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
diff --git a/src/Theme_AutoUpdates_Command.php b/src/Theme_AutoUpdates_Command.php
@@ -85,7 +85,7 @@ public function enable( $args, $assoc_args ) {
 		$themes       = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
@@ -162,7 +162,7 @@ public function disable( $args, $assoc_args ) {
 		$themes       = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
@@ -278,7 +278,7 @@ public function status( $args, $assoc_args ) {
 		$themes       = $this->fetcher->get_many( $args );
 		$auto_updates = get_site_option( static::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 
diff --git a/src/WP_CLI/ParseThemeNameInput.php b/src/WP_CLI/ParseThemeNameInput.php
@@ -76,7 +76,7 @@ private function get_all_themes() {
 
 		$auto_updates = get_site_option( Theme_AutoUpdates_Command::SITE_OPTION );
 
-		if ( false === $auto_updates ) {
+		if ( ! is_array( $auto_updates ) ) {
 			$auto_updates = [];
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public function enable( $args, $assoc_args ) {`
`85`	`85`	`$plugins = $this->fetcher->get_many( $args );`
`86`	`86`	`$auto_updates = get_site_option( static::SITE_OPTION );`
`87`	`87`
`88`		`- if ( false === $auto_updates ) {`
	`88`	`+ if ( ! is_array( $auto_updates ) ) {`
`89`	`89`	`$auto_updates = [];`
`90`	`90`	`}`
`91`	`91`
`@@ -162,7 +162,7 @@ public function disable( $args, $assoc_args ) {`
`162`	`162`	`$plugins = $this->fetcher->get_many( $args );`
`163`	`163`	`$auto_updates = get_site_option( static::SITE_OPTION );`
`164`	`164`
`165`		`- if ( false === $auto_updates ) {`
	`165`	`+ if ( ! is_array( $auto_updates ) ) {`
`166`	`166`	`$auto_updates = [];`
`167`	`167`	`}`
`168`	`168`
`@@ -278,7 +278,7 @@ public function status( $args, $assoc_args ) {`
`278`	`278`	`$plugins = $this->fetcher->get_many( $args );`
`279`	`279`	`$auto_updates = get_site_option( static::SITE_OPTION );`
`280`	`280`
`281`		`- if ( false === $auto_updates ) {`
	`281`	`+ if ( ! is_array( $auto_updates ) ) {`
`282`	`282`	`$auto_updates = [];`
`283`	`283`	`}`
`284`	`284`
Original file line number	Diff line number	Diff line change
`@@ -751,7 +751,7 @@ protected function get_item_list() {`
`751`	`751`
`752`	`752`	`$auto_updates = get_site_option( Plugin_AutoUpdates_Command::SITE_OPTION );`
`753`	`753`
`754`		`- if ( false === $auto_updates ) {`
	`754`	`+ if ( ! is_array( $auto_updates ) ) {`
`755`	`755`	`$auto_updates = [];`
`756`	`756`	`}`
`757`	`757`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ private function get_all_themes() {`
`76`	`76`
`77`	`77`	`$auto_updates = get_site_option( Theme_AutoUpdates_Command::SITE_OPTION );`
`78`	`78`
`79`		`- if ( false === $auto_updates ) {`
	`79`	`+ if ( ! is_array( $auto_updates ) ) {`
`80`	`80`	`$auto_updates = [];`
`81`	`81`	`}`
`82`	`82`